feat: rename shiki packages #3506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let’s cut another rc and wait for few days before releasing stable. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A full round circle, and now we are back to Shiki :P
The v1.0.0-beta.0 is the exact same implementation as the latest Shikiji, it shouldn't make any difference to end users.
The only breaking change is that
shikijiSetupis renamed toshikiSetup(it's easy to provide soft deprecation, but since we are in RC that breaking change is still acceptable + I did a quick search on the entire GitHub and it seems no many ppl is using that hook, should be easy to migration as well).As I don't expect more breaking changes from Shiki, the beta version is used to make sure everything works fine and the migration path is reasonable - It's ok to either have this now, or wait a few days for stable 1.0 release - either way should do the same.