Make git hook installation optional/controlled

[ziazon]

What problem does this feature solve?

per: https://cli.vuejs.org/guide/cli-service.html#git-hooks

when running npm ci or npm install it also force instals placeholders for all git hooks, which each looks for your packages.json file to see if there are any rules specified. This slows down git actions taken... even if you have no rules specified.

Can we somehow skip this step optionally? or opt into the use of yorkie?

Currently to resolve this I have to the run rm -fr .git/hooks/* any time I do an install.

What does the proposed API look like?

Perhaps install yorkie as a top level package and surface a vue create --no-git-hooks my-project option to not add the package which in turn won't install the git hooks.

[e-cloud]

Since husky has been updated with a lot of changes, yorkie may not be worthy to apply anymore.

[spaceneenja]

It does seem to resolve the core issue expressed in the "yorkie" fork.

From https://github.com/typicode/husky

// package.json
{
  "husky": {
    "hooks": {
      "pre-commit": "npm test",
      "pre-push": "npm test",
      "...": "..."
    }
  }
}

[P-Seebauer]

Since husky has been updated with a lot of changes, yorkie may not be worthy to apply anymore.

But the same goes for husky, it still installs the hooks if set as a dependency. So this issue would still arise.

[gnicol-bzh]

Thanks for pointing this! I was wondering why a simple commit tooks ~10 sec on a project, and was instant on others.

Removing .git/hooks, now my commits are instant on this project too.

Of course, the problematic project is our first project built with Vue CLI.

Before removing:

[15:54:05] Stage random.file for commit: started.
[15:54:05] Stage random.file for commit: finished.71ms
[15:54:11] Commit: started.
[15:54:11] pre-commit hook started.
[15:54:13] pre-commit hook finished. View hook log      2.586s
[15:54:13] prepare-commit-msg hook started.
[15:54:16] prepare-commit-msg hook finished. View hook log      2.599s
[15:54:16] commit-msg hook started.
[15:54:19] commit-msg hook finished. View hook log      2.577s
[15:54:19] post-commit hook started.
[15:54:21] post-commit hook finished. View hook log     2.663s
[15:54:21] Commit: finished creating commit 62f7...

After removing .git/hooks:

[16:02:09] Stage same-random.file for commit: started.
[16:02:09] Stage same-random.file for commit: finished.72ms
[16:02:15] Commit: started.
[16:02:15] Commit: finished creating commit b61...

Note: I use Gitkraken for all projects, so I always use the same "Git Command": press the [Commit] button 😉

Windows 10 pro 64
Intel Core i7-6820 @2.70GHz
16Gb
SSD

[jasonkarns]

Husky and Yorkie also clash with any existing hook management scheme like (the superior, IMO) https://github.com/git-hooks/git-hooks

[bviala]

bump