fix #10614: the select's v-model set to undefined in some corner case
#10615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d` in some corner case fix vuejs#10614
xieranmaya
commented
Oct 10, 2019
| @@ -118,7 +118,7 @@ function genSelect ( | |||
| `.map(function(o){var val = "_value" in o ? o._value : o.value;` + | |||
| `return ${number ? '_n(val)' : 'val'}})` | |||
|
|
|||
| const assignment = '$event.target.multiple ? $$selectedVal : $$selectedVal[0]' | |||
There was a problem hiding this comment.
$$selectedVal may be an empty array, this way we should not return its first element
reserve the model's previous value is a reasonable choice
|
@xieranmaya I'd like to get a fix for this bug into the next release. Do you mind if I open a PR off this branch that will fix this failing test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(select-model): fix the issue of select's v-model set to
undefinedin some corner casefix #10614
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: