Skip to content

feat(server): make MAX_STACK_DEPTH configurable #11298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Brooooooklyn
Copy link

@Brooooooklyn Brooooooklyn commented Apr 9, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

In my scenario, there are many recursive calls in render function, and SSR application would throw the Maximum call stack size exceeded before the stackDepth reach 800. I want the MAX_STACK_DEPTH to be configurable in this case.

@posva posva added the feat:ssr label Apr 9, 2020
@Brooooooklyn
Copy link
Author

@posva any plan to merge it?

@Brooooooklyn
Copy link
Author

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants