Skip to content

Set jsDelivr default file #6618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2017
Merged

Set jsDelivr default file #6618

merged 2 commits into from
Sep 18, 2017

Conversation

LukasDrgon
Copy link
Contributor

@LukasDrgon LukasDrgon commented Sep 15, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:
    Setting a default file for jsDelivr

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@yyx990803
Copy link
Member

Thanks - just to be consistent, we expose the non-minified build (dist/vue.js) at default CDN urls because the shorthands are more frequently used for prototyping, debugging and teaching purposes. In production we recommend always using an explicitly versioned CDN link.

@LukasDrgon
Copy link
Contributor Author

Makes sense. I updated the PR.

@yyx990803 yyx990803 merged commit a9b6bc4 into vuejs:dev Sep 18, 2017
ztlevi pushed a commit to ztlevi/vue that referenced this pull request Feb 14, 2018
lutovich added a commit to lutovich/neo4j-javascript-driver that referenced this pull request Apr 4, 2018
Short urls are often used for non-production code and it make sense
for referenced file to not be minified. See discussion in
vuejs/vue#6618 for more information.
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants