Skip to content

Migration to Typescript #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Jul 15, 2019
Merged

Migration to Typescript #302

merged 39 commits into from
Jul 15, 2019

Conversation

posva
Copy link
Member

@posva posva commented Jul 15, 2019

Migrated the whole project to TS
Also added changes at vuejs/vue#10272

@codecov-io
Copy link

codecov-io commented Jul 15, 2019

Codecov Report

Merging #302 into master will increase coverage by 0.05%.
The diff coverage is 99.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
+ Coverage   99.67%   99.73%   +0.05%     
==========================================
  Files           9       14       +5     
  Lines         308      371      +63     
  Branches       53       64      +11     
==========================================
+ Hits          307      370      +63     
  Misses          1        1
Impacted Files Coverage Δ
packages/vuexfire/src/mutations-types.ts 100% <ø> (ø)
packages/vuexfire/src/firestore.ts 100% <100%> (ø)
...ackages/@posva/vuefire-core/src/firestore/index.ts 100% <100%> (ø)
packages/vuexfire/src/rtdb.ts 100% <100%> (ø)
packages/vuexfire/src/index.ts 100% <100%> (ø)
packages/@posva/vuefire-core/src/index.ts 100% <100%> (ø)
packages/vuefire/src/rtdb.ts 100% <100%> (ø)
packages/@posva/vuefire-core/src/rtdb/index.ts 100% <100%> (ø)
packages/vuexfire/src/mutations.ts 100% <100%> (ø)
packages/@posva/vuefire-core/src/shared.ts 100% <100%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5636d1e...c504fa4. Read the comment docs.

@posva
Copy link
Member Author

posva commented Jul 15, 2019

Note to myself not to squash this one. I need to do a few local tests in projects to make sure everything still works the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants