-
Notifications
You must be signed in to change notification settings - Fork 169
Add new entrypoints to webcomponentsjs for the 'platform' polyfills. #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ag-parser' to 'sd-ce-pf' (and 'bundle') entrypoint only.
…or `:unresolved`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, I don't have an opinion about the names.
Can you remind me why we need to make these entrypoints for lit next (or update PR description)? I don't remember the discussion.
Shady DOM and the custom elements polyfill both use the @webcomponents/webcomponents-platform package in some of their tests but we no longer have @webcomponents/webcomponents-platform as a distinct package in our source after merging all of the polyfill repos, so we can't update them (without recreating the package). These entrypoints will give us a place to put the newer polyfills that we're adding for Lit ( |
? |
Or |
I think I might just go with the |
Just using 'js' and 'dom' for these bundles is confusing, especially considering that this would add file with these names to the package: - `bundle/webcomponents-js.js` - `bundle/webcomponents-dom.js` - `src/entrypoints/webcomponents-js-index.js` - `src/entrypoints/webcomponents-dom-index.js`
Ok, updated, anyone opposed? |
Fixes #386.
I think the names for these bundles need some bikeshedding. Having these file names in the package is probably going to be very confusing for consumers:
pf
is used in the other bundle names for 'platform' but now that they're split into two, we need some new separate name for each.js
anddom
were just the most obvious, but clearly aren't helpful if you're just looking around at the files in this package.