fix(accessibility): update download button visibility and styles #1453

khushi19099 · 2025-05-22T04:09:10Z

Pull Request Description

Problem Statement

The download button in the Content tab is only visible on hover and not accessible via keyboard navigation, creating accessibility issues for keyboard-only users.

Solution

Added permanent visibility to download button in Content tab view
Enhanced keyboard navigation with proper focus states
Improved button styling and positioning for better accessibility

Testing Done

Keyboard Navigation
- Tab through Content tab items
- Verify download button is focusable
- Check focus indicators are clearly visible
Visual Testing
- Download button is permanently visible without hover
- Button is properly centered
- Focus states are visually clear
Accessibility Testing
- Tested with VoiceOver (⌘ + F5)
- Verified ARIA labels are properly announced
- Checked color contrast ratios

Screenshots

Related Issues

Fixes SPARK-564418

Dependencies

None

Pull Request Description

Problem Statement

The download button in the Content tab is only visible on hover and not accessible via keyboard navigation, creating accessibility issues for keyboard-only users.

Solution

Added permanent visibility to download button in Content tab view
Enhanced keyboard navigation with proper focus states
Improved button styling and positioning for better accessibility
Added ARIA labels for screen reader support

Testing Done

Keyboard Navigation
- Tab through Content tab items
- Verify download button is focusable
- Check focus indicators are clearly visible
Visual Testing
- Download button is permanently visible without hover
- Button is properly centered
- Focus states are visually clear
Accessibility Testing
- Tested with VoiceOver (⌘ + F5)
- Verified ARIA labels are properly announced
- Checked color contrast ratios

Screenshots

[Before/After screenshots to be added]

Related Issues

Fixes SPARK-XXXX: Content tab download button accessibility

Browser Testing

Chrome
Firefox
Safari

Dependencies

None

Notes

The changes include CSS !important declarations to override existing styles.

coderabbitai · 2025-05-22T04:09:16Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)

packages/node_modules/@webex/widget-files/src/components/ShareListingItem.js is excluded by !**/node_modules/**
packages/node_modules/@webex/widget-files/src/styles.css is excluded by !**/node_modules/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

aws-amplify-us-east-2 · 2025-05-22T04:15:22Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1453.d1l3lxgizk4iez.amplifyapp.com

bhabalan · 2025-05-22T05:01:26Z

@CodeRabbit review

coderabbitai · 2025-05-22T05:01:31Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

packages/node_modules/@webex/widget-files/src/styles.css

packages/node_modules/@webex/widget-files/src/components/ShareListingItem.js

packages/node_modules/@webex/widget-files/src/styles.css

rarajes2 · 2025-05-30T04:33:46Z

packages/node_modules/@webex/widget-files/src/styles.css

+
+/* Focus styles for keyboard navigation */
+.content-tab .file-download-wrapper .md-button-circle:focus-visible {
+  outline: 2px solid #0073C6;


We are not supposed to use hardcoded value for color. Please use momentum color vars. you can check in other packages how we use it.

fix(spacewidget): update download button visibility and styles

f3b5b79

Shreyas281299 requested changes May 23, 2025

View reviewed changes

packages/node_modules/@webex/widget-files/src/styles.css Outdated Show resolved Hide resolved

packages/node_modules/@webex/widget-files/src/components/ShareListingItem.js Outdated Show resolved Hide resolved

rarajes2 reviewed May 23, 2025

View reviewed changes

packages/node_modules/@webex/widget-files/src/styles.css Outdated Show resolved Hide resolved

rarajes2 reviewed May 23, 2025

View reviewed changes

packages/node_modules/@webex/widget-files/src/styles.css Outdated Show resolved Hide resolved

fix(spacewidget): address PR comments for download button accessibility

bd481f2

rarajes2 reviewed May 30, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(accessibility): update download button visibility and styles #1453

fix(accessibility): update download button visibility and styles #1453

Uh oh!

khushi19099 commented May 22, 2025

Uh oh!

coderabbitai bot commented May 22, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

aws-amplify-us-east-2 bot commented May 22, 2025

Uh oh!

bhabalan commented May 22, 2025

Uh oh!

coderabbitai bot commented May 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rarajes2 May 30, 2025

Uh oh!

Uh oh!

fix(accessibility): update download button visibility and styles #1453

Are you sure you want to change the base?

fix(accessibility): update download button visibility and styles #1453

Uh oh!

Conversation

khushi19099 commented May 22, 2025

Pull Request Description

Problem Statement

Solution

Testing Done

Screenshots

Related Issues

Dependencies

Pull Request Description

Problem Statement

Solution

Testing Done

Screenshots

Related Issues

Browser Testing

Dependencies

Notes

Uh oh!

coderabbitai bot commented May 22, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

aws-amplify-us-east-2 bot commented May 22, 2025

Uh oh!

bhabalan commented May 22, 2025

Uh oh!

coderabbitai bot commented May 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rarajes2 May 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CodeRabbit Configuration File (`.coderabbit.yaml`)