Skip to content
This repository was archived by the owner on Jan 6, 2024. It is now read-only.

feat(assets): add scroll driven animations #150

Merged
merged 2 commits into from
Jul 20, 2023
Merged

feat(assets): add scroll driven animations #150

merged 2 commits into from
Jul 20, 2023

Conversation

jahnli
Copy link
Contributor

@jahnli jahnli commented Jul 19, 2023

chrome_w27NaOduyR

@jahnli
Copy link
Contributor Author

jahnli commented Jul 19, 2023

I tried to use unocss, but only animation and keyframes were implemented, animation-timeline animation-range was not implemented

@webfansplz webfansplz changed the title feat: add scroll driven animations feat(assets): add scroll driven animations Jul 20, 2023
@webfansplz webfansplz merged commit e266b1d into webfansplz:main Jul 20, 2023
@jahnli
Copy link
Contributor Author

jahnli commented Jul 20, 2023

@webfansplz It runs under chrome115, if so, do I need to add list to all displays? I would work for it if I could

@webfansplz
Copy link
Owner

Is there any issue with it below chrome115?

@webfansplz
Copy link
Owner

In addition, let's experiment with it in this tab for a moment.

@jahnli
Copy link
Contributor Author

jahnli commented Jul 20, 2023

@webfansplz As far as I know, scroll driven animations were not supported until chrome115. Below chrome115, just no different from before, but there is no transition

@webfansplz
Copy link
Owner

Later, I will add this effect to other lists

Let's experiment with it in this tab for a moment.

@jahnli
Copy link
Contributor Author

jahnli commented Jul 20, 2023

@webfansplz #148 Could you please help me to see how to solve this problem? If there is a scroll bar and the drag bar overlap, there will be a conflict that will cause scrolling failure. Now I just adjust the spacing, or can you see if there is a more reasonable solution

@OneGIl
Copy link
Contributor

OneGIl commented Jul 20, 2023

animation-timeline以及animation-range属性在MDN中显示为实验性质(7月18日才成为实验性质的属性),其他浏览器也未跟进,不能保证api会不会改变,也不能保证能成为新的规范。总感觉有些过于激进,不知道这种尝试是否合理?在api基本定型的阶段再考虑该feat是否会更好呢?

@jahnli
Copy link
Contributor Author

jahnli commented Jul 20, 2023

Yes, so I just tried it in the assets TAB, and while it was experimental, the code didn't have any effect on what it actually looked like

@webfansplz
Copy link
Owner

webfansplz commented Jul 20, 2023

animation-timeline以及animation-range属性在MDN中显示为实验性质(7月18日才成为实验性质的属性),其他浏览器也未跟进,不能保证api会不会改变,也不能保证能成为新的规范。总感觉有些过于激进,不知道这种尝试是否合理?在api基本定型的阶段再考虑该feat是否会更好呢?

目前只会在assets菜单中实验,即使后面有破坏性改动的话,也不会影响功能,只是会没有动画而已。另外我会考虑是否要在Vue DevTools发V1.0正式版的时候保留它,或者只是在Alpha保留它。

@OneGIl OneGIl mentioned this pull request Jul 20, 2023
@OneGIl
Copy link
Contributor

OneGIl commented Jul 20, 2023

感谢二位的回复!
只不过,经过我的测试,在Mac下的Edge(v114),Firefox(v115),Safari(v16)无法正确展示assets里的内容(Chrome的114版本没有条件测试)。因为Edge是我的主力浏览器,这种问题的确会影响当前的开发,也可能会影响到其他使用非Chrome的开发者。

最后想请教一下,在不影响该pr以及不更换浏览器的情况下,我应该怎么做才能“优雅一些”的开发assets部分,因为我想试试 #154 这个。

image

@jahnli
Copy link
Contributor Author

jahnli commented Jul 21, 2023

感谢二位的回复! 只不过,经过我的测试,在Mac下的Edge(v114),Firefox(v115),Safari(v16)无法正确展示assets里的内容(Chrome的114版本没有条件测试)。因为Edge是我的主力浏览器,这种问题的确会影响当前的开发,也可能会影响到其他使用非Chrome的开发者。

最后想请教一下,在不影响该pr以及不更换浏览器的情况下,我应该怎么做才能“优雅一些”的开发assets部分,因为我想试试 #154 这个。

image

我会在稍后测试这个问题

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants