Fix known type names validation for fragments with experimental variables #1707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes building a schema with
experimentalFragmentVariables
.Currenty, the
DocumentValidator
returnsUnknown type "String"
.Example:
Fragments should also implement
TypeSystemDefinitionNode
to have the type names validated against theType::BUILT_IN_TYPE_NAMES
by theGraphQL\Validator\Rules\KnownTypeNames
rule:Sorry, i struggled to add a test for this case with the current mock data in the
KnownTypeNamesTest
. Please advise if it is required.