Skip to content

docs(README): fix malformed link (options.alias) #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ahoym
Copy link
Contributor

@ahoym ahoym commented Aug 18, 2017

Fixes:

What kind of change does this PR introduce?
README fix

Did you add tests for your changes?
No code changes, just markdown fix. Here's the test:


Before:
css-loader's alias follows the same syntax as webpack's resolve.alias, you can see the details at the [resolve docs] (https://webpack.js.org/configuration/resolve/#resolve-alias)

After:
css-loader's alias follows the same syntax as webpack's resolve.alias, you can see the details at the resolve docs


If relevant, did you update the README?
Yes, made a super minor fix to it

Motivation
Saw an incorrectly formatted link, wanted to fix it

Does this PR introduce a breaking change?
No breaking changes

Fixes:
[link text] (link) ---> [link text](link)
@jsf-clabot
Copy link

jsf-clabot commented Aug 18, 2017

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@michael-ciniawsky michael-ciniawsky changed the title Fix markdown for link to webpack resolve.alias doc docs(README): fix malformed link to webpack docs (options.alias) Aug 18, 2017
@michael-ciniawsky michael-ciniawsky changed the title docs(README): fix malformed link to webpack docs (options.alias) docs(README): fix malformed link (options.alias) Aug 18, 2017
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahoym Thx

@ahoym
Copy link
Contributor Author

ahoym commented Aug 22, 2017

👍 , happy to help

@alexander-akait alexander-akait merged commit 0840c80 into webpack-contrib:master Sep 1, 2017
@ahoym ahoym deleted the fix/readme-resolve-alias-link branch September 1, 2017 16:45
@TheLarkInn
Copy link
Contributor

Thank you for this!!!🙇🙇🙇🙇♥️

@michael-ciniawsky michael-ciniawsky removed this from the 0.28.9 milestone Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants