Skip to content

refactor: use snapshots for some tests #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Nov 26, 2018

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Migrate to snapshot testing in tests

Breaking Changes

No

Additional Info

Use babel for jest to allow using async/await

Find two bugs:

  • URL (in @import URL()) are not handled.
  • Same @import with difference case of media (screen, SCREEN) handled as difference import.
  • Warnings from postcss are not processed.

Will be fixed in other PRs

@alexander-akait
Copy link
Member Author

Feel free to feedback

@alexander-akait alexander-akait merged commit 8f0232b into master Nov 26, 2018
@alexander-akait alexander-akait deleted the refactor-test branch November 26, 2018 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant