Skip to content
This repository was archived by the owner on Sep 28, 2020. It is now read-only.

Remove unused dependency find-cache-dir #170

Merged
merged 1 commit into from
Jun 15, 2017
Merged

Remove unused dependency find-cache-dir #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,7 @@ some issues cannot be fixed properly.**
This option will enable caching of the linting results into a file.
This is particularly useful in reducing linting time when doing a full build.

The cache file is written to the `./node_modules/.cache` directory, thanks to the usage
of the [find-cache-dir](https://www.npmjs.com/package/find-cache-dir) module.
The cache file is written to the `./node_modules/.cache` directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just remove this, since the module we use might change something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel it is kind of important to mention where the cache is stored. In our case we persist this folder between 2 CI run and have some clean up script to prevent it to grow too much.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So at least we should say "The cache file is probably written to"... (Because if the module change the path, this doc will be irrelevant).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't node_modules/.cache the standard location for caching? We also fallback to os temp dir if it fails to write to ./node_modules/.cache

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My idea is: since we use a module that handle this, we don't really know what the deps will rely on, so maybe we should say "we use X" with a link so people can have an up to date link? I am just afraid this doc become out of date someday :)


#### `formatter` (default: eslint stylish formatter)

Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
"eslint": ">=1.6.0 <4.0.0"
},
"dependencies": {
"find-cache-dir": "^0.1.1",
"loader-fs-cache": "^1.0.0",
"loader-utils": "^1.0.2",
"object-assign": "^4.0.1",
Expand Down