feat(client): respect infrastructureLogging.level on Browser side as well #2889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiroppy
force-pushed
the
feature/respect-infrastructureLogging
branch
from
358eadc to
575abca
Compare
hiroppy
force-pushed
the
feature/respect-infrastructureLogging
branch
from
575abca to
ef88d0f
Compare
| this.sockWrite([connection], 'logging', this.options.client.logging); | ||
| const clientLogLevel = | ||
| this.options.client.logging || | ||
| (this.compiler.options.infrastructureLogging && |
There was a problem hiding this comment.
Compilers can be array here
There was a problem hiding this comment.
Ideally it should be on plugin level (and getting from the compilation), but it is require more complex logic
There was a problem hiding this comment.
Note there is getCompilerConfigArray() util.
There was a problem hiding this comment.
Yes, it should be easy to fix
There was a problem hiding this comment.
Good catch, I'll fix this tomorrow.
6 tasks
|
Closing in favor of #3613 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Motivation / Use-Case
I think the existence of both infrastructureLogging.level and client.logger is confusing. So if client.logger is empty but infrastructureLogging.level is set, we should respect infrastructureLogging.level on Browser side as well.
This is my proposal so what do you think? @alexander-akait
If you agree with this, I'll add tests.
#2887
Breaking Changes
no
Additional Info