fix: update webpack peer dependency to ^4.37.0 #3650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When webpack-dev-server is run on any webpack version < 4.37, this error appears.
[webpack-cli] TypeError: compiler.getInfrastructureLogger is not a function
This is because `compiler.getInfrastructureLogger` is introduced in webpack v4.37, therefore webpack-dev-server is not compatible with any version of webpack below it.
dtinth
requested review from
alexander-akait,
anshumanv,
hiroppy,
knagaitsev and
snitin315
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3650 +/- ##
==========================================
+ Coverage 93.87% 94.03% +0.15%
==========================================
Files 15 15
Lines 1289 1290 +1
Branches 443 443
==========================================
+ Hits 1210 1213 +3
+ Misses 72 70 -2
Partials 7 7
Continue to review full report at Codecov.
|
|
这个问题现在依然存在 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
No, this is a metadata update.
Motivation / Use-Case
When webpack-dev-server is run on any webpack version < 4.37, this error appears.
This is because
compiler.getInfrastructureLoggeris introduced in webpack v4.37, therefore webpack-dev-server is not compatible with any version of webpack below it.Breaking Changes
None.
Additional Info
We hit this error when using
[email protected]with[email protected].