Skip to content

fix(links): fix anchor links to /configuration/output #2940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2019

Conversation

svlapin
Copy link
Contributor

@svlapin svlapin commented Apr 12, 2019

fix(links): fix anchor links to /configuration/output

related to #2929

Fixed broken anchor links:

  • /configuration/output#output-librarytarget -> /configuration/output#outputlibrarytarget
  • /configuration/output#output-library -> /configuration/output#outputlibrary

Some takeaways (also answering @montogeek 's question)

Why this wasn't catch by the link checker?

  • on travis only lint:links runs, which executes hyperlink with -i flag. Looks like in this case fragment links are not checked at all
  • hyperlink does not correctly check fragment links pointing to folders having index.html inside.

@svlapin svlapin changed the title fix(links): fix anchor links to /output fix(links): fix anchor links to /configuration/output Apr 12, 2019
@EugeneHlushko EugeneHlushko merged commit 1f7ad71 into webpack:master Apr 19, 2019
@EugeneHlushko
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants