chore: updated the docs to mention correct loader #3353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready Built with commit 4c233fa https://deploy-preview-3353--webpackjsorg-netlify.netlify.com |
montogeek
approved these changes
Nov 15, 2019
|
Thanks for your contribution, What happened with the yarn.lock? Could you please revert those changes? |
|
that is using yarn install at the beginning. |
|
Yes please revert lockfile, can you also mention OS and node version to understand why so many changes in the lockfile after your install |
|
node : v10.15.3 |
|
Yeap do looks like the changes are related to mac vs win. As soon as its reverted should be good to go |
anikethsaha
force-pushed
the
fix/loader-api-adddependency
branch
from
f3c5cc5 to
9c43f14
Compare
anikethsaha
force-pushed
the
fix/loader-api-adddependency
branch
from
9c43f14 to
4c233fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
html-loaderdoesnt usesaddDependencymethod, Might be outdated with the changesI changed the example with
sass-loaderandless-loaderwhich does use it