Re-export RunError and PooledConnection from bb8 #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnchildren
force-pushed
the
re-export-bb8-run-error
branch
from
7ec2ca1 to
523ca2f
Compare
johnchildren
force-pushed
the
re-export-bb8-run-error
branch
from
523ca2f to
5d5195d
Compare
johnchildren
changed the title
|
Thanks for opening this PR. I potentially plan to relicense diesel-async in the future. Because of that I need an explicitly written consent that you transfer the ownership of this change to me. Please add that to the commit message. |
Re-export type aliases for RunError and PooledConnection for the bb8 connection pool. I consent that I transfer the ownership of this change to weiznich (Georg Semmler).
johnchildren
force-pushed
the
re-export-bb8-run-error
branch
from
5d5195d to
e86b86b
Compare
Thank you, consent added! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-export the
RunErrortype from bb8. Required when handling errors from the pool.Edit: Updated to include the specific
PoolErrorin the type alias and to include PooledConnection.