Fix/incorrect state judgment causes stability to remain unchanged #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

xiaohajiayou merged 2 commits into xiaohajiayou:main from ishiko732:Fix/wrong-get-next-state

Mar 30, 2025

Contributor

ishiko732 commented Mar 30, 2025

close #27

ishiko732 added 2 commits

March 30, 2025 22:36


          Fix/incorrect state judgment causes stability to remain unchanged

e0099e2


          avoid undefined

ed95ad5

Contributor Author

ishiko732 commented Mar 30, 2025

长期调度模式下，due永远会比传进去的now大1天
现阶段FSRS高阶方法内部只会报类型不匹配/无效问题，在单元测试100%的情况下，我不确定什么情况会触发到catch分支
lastReview字段只要被fsrs调度过就不会是undefined

Contributor Author

ishiko732 commented Mar 30, 2025

before:

after:

xiaohajiayou merged commit d00cb88 into xiaohajiayou:main

Owner

xiaohajiayou commented Mar 30, 2025

确实存在这个问题，之前有疑惑多次复习的调度增速较慢，但是没有注意，感谢帮忙修正~

ishiko732 deleted the Fix/wrong-get-next-state branch

March 31, 2025 00:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet