Skip to content

add to_human_string #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Conversation

stingray-11
Copy link
Contributor

@stingray-11 stingray-11 commented Jan 13, 2023

Adds to_human_string() for better error strings. Some may need tweaking, I took an educated guess on a few.

@stingray-11
Copy link
Contributor Author

Not sure why the windows test failed, doesn't look related to this.

@yhirose
Copy link
Owner

yhirose commented Jan 18, 2023

@stingray-11 sorry for the late reply. I don't mind to replace the existing to_string method with your more human readable string instead of introducing to_human_string. Could you make the change? Thanks!

@stingray-11
Copy link
Contributor Author

@stingray-11 sorry for the late reply. I don't mind to replace the existing to_string method with your more human readable string instead of introducing to_human_string. Could you make the change? Thanks!

Done!

@yhirose yhirose merged commit 51607ec into yhirose:master Jan 19, 2023
@yhirose
Copy link
Owner

yhirose commented Jan 19, 2023

@stingray-11 thanks for your contribution!

ExclusiveOrange pushed a commit to ExclusiveOrange/cpp-httplib-exor that referenced this pull request May 2, 2023
* add to_human_string

* replace to_string with to_human_string

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants