Add zstd support

[davidalo]

No description provided.

[falbrechtskirchinger]

FYI, the broken tests are fixed by #2089 and #2090.

[yhirose]

@davidalo could you rebase your code based on the latest master branch, and fix the format errors reported by 'test/style-check'? Thanks!

[davidalo]

@davidalo could you rebase your code based on the latest master branch, and fix the format errors reported by 'test/style-check'? Thanks!

Done!

[davidalo]

All tests are passing on my side.

[falbrechtskirchinger]

All tests are passing on my side.

Well, is CI running any of the tests? (Ignoring the internal server error on GH's end.) On Ubuntu and macOS, tests are run through test/Makefile. And on Windows (where we use CMake), we don't have the dependencies (I assume).

Let me know if you need assistance with any of that.

[yhirose]

@davidalo as @falbrechtskirchinger mentioned, the unit tests should run on the GitHub Actions CI. The following lines are for the Brotri support. You can do the same or similar for the zstd support.

cpp-httplib/test/Makefile

Lines 18 to 21 in 85b5cdd

	BROTLI_DIR = $(PREFIX)/opt/brotli
	BROTLI_SUPPORT = -DCPPHTTPLIB_BROTLI_SUPPORT -I$(BROTLI_DIR)/include -L$(BROTLI_DIR)/lib -lbrotlicommon -lbrotlienc -lbrotlidec
	TEST_ARGS = gtest/gtest-all.cc gtest/gtest_main.cc $(OPENSSL_SUPPORT) $(ZLIB_SUPPORT) $(BROTLI_SUPPORT) -pthread -lcurl

cpp-httplib/.github/workflows/test.yaml

Line 54 in 85b5cdd

run: sudo apt-get update && sudo apt-get install -y libbrotli-dev libcurl4-openssl-dev

cpp-httplib/.github/workflows/test.yaml

Line 106 in 85b5cdd

run: vcpkg install gtest curl zlib brotli

cpp-httplib/.github/workflows/test.yaml

Line 117 in 85b5cdd

-DHTTPLIB_REQUIRE_BROTLI=ON

[sum01]

Don't forget to add to httplibConfig.cmake.in

[yhirose]

@davidalo could you please follow up the review comments? Thanks!

[davidalo]

@davidalo could you please follow up the review comments? Thanks!

Yes, sorry busy week... Pushed three commits with the requested changes but suffering from conflicts. Rebasing and solving conflicts now.

[davidalo]

@yhirose @sum01 @falbrechtskirchinger fixed following your comments, thanks for them. Tests pass, except for the abi test, which fails for something unrelated to this PR. Please check it now.

[falbrechtskirchinger]

Tests pass, except for the abi test, which fails for something unrelated to this PR. Please check it now.

Don't worry about the ABI test, it's purely informational and (mostly) intended for the maintainer.

For CMake, you still need to add ZStd to https://github.com/yhirose/cpp-httplib/blob/master/cmake/httplibConfig.cmake.in. Someone else can take care of Meson after the PR has been merged.

I'm short on time and will do a detailed review later if no one else does.

[davidalo]

Don't worry about the ABI test, it's purely informational and (mostly) intended for the maintainer.

For CMake, you still need to add ZStd to https://github.com/yhirose/cpp-httplib/blob/master/cmake/httplibConfig.cmake.in. Someone else can take care of Meson after the PR has been merged.

I'm short on time and will do a detailed review later if no one else does.

Thanks for your comments, added zstd to httplibConfig.cmake.in

[yhirose]

@davidalo thanks for your fine contribution!

[davidalo]

Thanks everyone for your review and for this great library!