Skip to content

Test using latest numpy #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

Test using latest numpy #3064

merged 2 commits into from
May 28, 2025

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented May 15, 2025

This is a bit of an experiment to see if using '2' will give us the latest verison of numpy to test on

This bumps to the latest version of numpy. We still need to fix typing to work with numpy 2.2, but worth running tests for now at least.

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label May 15, 2025
@jhamman
Copy link
Member

jhamman commented May 16, 2025

+1 on this change if we can make it work. I seem to remember trying and failing but it seems like it should work.

@dstansby
Copy link
Contributor Author

So the problem with using ~ is that

This operator MUST NOT be used with a single segment version number such as ~=1.

(see PEP 440)

I'm trying out using .* instead with ==

@dstansby dstansby force-pushed the npy-22 branch 2 times, most recently from 4ac8baf to 3cc0153 Compare May 25, 2025 09:36
@dstansby
Copy link
Contributor Author

Bah that didn't work. I just bumped the version number, evenually we can get rid of a lot of this anyway when we drop support for numpy 1

@dstansby dstansby marked this pull request as ready for review May 25, 2025 13:36
@dstansby dstansby removed the needs release notes Automatically applied to PRs which haven't added release notes label May 25, 2025
@dstansby dstansby requested review from d-v-b and jhamman May 28, 2025 09:20
@dstansby dstansby enabled auto-merge (squash) May 28, 2025 09:22
@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label May 28, 2025
@dstansby dstansby merged commit ada3b22 into zarr-developers:main May 28, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants