zephyrCommon: Add tone and noTone #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Ayush1325
commented
Jun 6, 2024
•
Ayush1325
commented
- Add implementation of tone and noTone
- Add sample. Taken from https://github.com/arduino/arduino-examples/blob/main/examples/02.Digital/toneMelody/toneMelody.ino
- Tested on bcf
6 tasks
Ayush1325
force-pushed
the
tone
branch
2 times, most recently
from
bda0532 to
8f2a766
Compare
soburi
requested changes
Jun 9, 2024
Ayush1325
force-pushed
the
tone
branch
4 times, most recently
from
750d40a to
8d0173d
Compare
|
Found a piezo buzzer and tested with bcf. Also fixed the case for frequency = 0. |
DhruvaG2000
requested changes
Jun 10, 2024
|
@DhruvaG2000 What should I do regarding copyright and license? |
soburi
reviewed
Jun 14, 2024
soburi
reviewed
Jun 14, 2024
DhruvaG2000
requested changes
Jun 25, 2024
Ayush1325
force-pushed
the
tone
branch
2 times, most recently
from
5d66eb1 to
5b4d8c9
Compare
DhruvaG2000
reviewed
Jun 26, 2024
|
@DhruvaG2000 I think it might be best to remove the example from this PR. The upstream example can be used without any modification, so it is not particularly important to have it here, especially blocking this PR. |
- Add implementation of tone and noTone - Use another one-shot timer to stop the first timer. - Silence when frequency = 0 Signed-off-by: Ayush Singh <[email protected]>
soburi
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.