Skip to content

Create tuya_valve_tz3000_iedbgyxt.py to correct valve showing as light #4104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

derekcentrico
Copy link

#4103 (comment)

This quirk is working here. It might not be the cleanest so I understand if you all decline and modify/add yourselves.

Proposed change

Adds switch/valve functionality to a device that was mismatched as a light.

Additional information

Should fix #4103

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

derekcentrico and others added 2 commits May 31, 2025 17:39
zigpy#4103 (comment)

This quirk is working here.  It might not be the cleanest so I understand if you all decline and modify/add yourselves.
@TheJulianJES TheJulianJES added Tuya Request/PR regarding a Tuya device needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state). v2 quirk candidate This PR is a good fit to be converted to a v2 quirk. labels May 31, 2025
@derekcentrico derekcentrico changed the title Create tuya_valve_tz3000_iedbgyxt.py Create tuya_valve_tz3000_iedbgyxt.py to correct valve showing as light Jun 1, 2025
derekcentrico and others added 6 commits June 1, 2025 08:26
Should fix the two ruff issues.
Trying to get past the auto bot stuff to match what is required for the repo.  Learning.
I think this fixes the RUFF issues.  However, I do not know how to get past the  Cluster ID Test Failure.
@derekcentrico
Copy link
Author

@puddly Hey sorry to bother you, but any advice on what I'm doing so badly wrong here? The quirk works but I can't beat the bots. 🥇 for bot losses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state). Tuya Request/PR regarding a Tuya device v2 quirk candidate This PR is a good fit to be converted to a v2 quirk.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Device Support Request] Zigbee Water Valve Shutoff (currently works as a "light")
2 participants