Escaped bracket not ignored

[cbcoutinho]

Technically a repost of Issue #138 (the second part of the issue was not addressed in #455)

The following snippet incorrectly renders the last bracket as an error:

echo [ \] ]

[phy1729]

What #455 did was remove the attempt to ignore quoted braces. That means both echo [ ] and echo '[ ]' have highlighted brackets. The only way to correctly ignore brackets in quotes would be to basically merge the main and brackets highlighters (e.g. echo "${:-"["}" all are quoted, but it would take parsing the parameter expansion to know there's a new quoting context.)

[cbcoutinho]

I understand what issue was solved with #455, what I meant was that the OPs second point wasn't addressed by the PR that closed that issue. instead of commenting there I opened a new issue.

[phy1729]

I see what you mean now.

Since both backslash escapes and single quotes are a form of quoting, why should \[ be treated differently than '['?

[cbcoutinho]

I can't think of a general rule that satisfies all cases, but here are a couple examples that led me to this issue:

Quoted bracket that should be highlighted, such as executing an SQL query from the command line. In this case highlighting is desired:

$ sqlite mydata.db 'SELECT COUNT(mynumber) AS number FROM mytable;'

Escaped brackets in a regex expression shouldn't be highlighted

grep '\[+' myfile

[danielshahaf]

More cases for y'all: grep '(foo)', with/without backslashes inside the quotes, with/without -E (in BRE, parentheses are metacharacters when escaped, but in ERE, when unescaped); grep -o \[a-z\]\\+; printf '\e[42;'; bindkey '^[s'.

[phy1729]

I could see adding a case

\\)
(( SOME_VAR )) && pos++
;;

If you want to add that, could you also add a few tests for it?

[cbcoutinho]

I would be happy to add some tests, but I have no idea where to start or how to test - I'm going to look at test-highlighting.zsh for guidance. Thanks for the example tests Op za 22 sep. 2018 19:40 schreef Matthew Martin <notifications@github.com>:

…

I could see adding a case \\) (( SOME_VAR )) && pos++ ;; If you want to add that, could you also add a few tests for it? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#532 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMTd7KSkCZ6fYfJoJeTwpi8iWgstSP7vks5udnX4gaJpZM4WqG2K> .

[phy1729]

There are some docs at https://github.com/zsh-users/zsh-syntax-highlighting/tree/master/tests . If anything is unclear there, please point it out.