Reworked retry policy functionality & Created IMDS retry policy #5231

Robbie-Microsoft · 2025-04-11T21:09:14Z

.NET's retry policy functionality now aligns with MSAL-Node. This PR was already implemented in MSAL-Node, here.

There are now two retry strategies:
LinearRetryStrategy and ExponentialRetryStrategy

There are now two retry policies, which use the retry strategies:
ImdsRetryPolicy and DefaultRetryPolicy (both ESTS and non-IMDS Managed Identity HttpManagers use DefaultRetryPolicy)

The unit tests in this PR are ported from the MSAL-Node PR:
All retry policy unit tests run "100 times faster" by overriding certain variables; Retry policy tests are no longer "expensive".

src/client/Microsoft.Identity.Client/Http/HttpManager.cs

src/client/Microsoft.Identity.Client/Http/NoRetryPolicy.cs

src/client/Microsoft.Identity.Client/Http/IRetryPolicy.cs

src/client/Microsoft.Identity.Client/Http/DefaultRetryPolicy.cs

src/client/Microsoft.Identity.Client/Http/HttpManager.cs

src/client/Microsoft.Identity.Client/Http/ImdsRetryPolicy.cs

…f of this one.

…ests.

…yPolicy unit tests. Wrote UAMI unit tests for DefaultRetryPolicy.

…RetryPolicy tests.

…nit tests. Fixed some bugs discovered by unit tests.

…eAD/microsoft-authentication-library-for-dotnet into rginsburg/imds_retry_policy

src/client/Microsoft.Identity.Client/Http/ExponentialRetryStrategy.cs

src/client/Microsoft.Identity.Client/Http/LinearRetryStrategy.cs

src/client/Microsoft.Identity.Client/Http/DefaultRetryPolicy.cs

…5300)

… tests (#5308) * Created a prod and test retry policy factories, and adjusted unit tests * Retry Policy tests no longer rely on NumRetries static variable from individual retry policies (#5311) Replaced NumRetries static variable tests with QueueSize tests

neha-bhargava reviewed Apr 11, 2025

View reviewed changes

src/client/Microsoft.Identity.Client/Http/HttpManager.cs Outdated Show resolved Hide resolved

neha-bhargava reviewed Apr 11, 2025

View reviewed changes

src/client/Microsoft.Identity.Client/Http/NoRetryPolicy.cs Outdated Show resolved Hide resolved

bgavrilMS reviewed Apr 14, 2025

View reviewed changes

src/client/Microsoft.Identity.Client/Http/IRetryPolicy.cs Outdated Show resolved Hide resolved

bgavrilMS reviewed Apr 14, 2025

View reviewed changes

src/client/Microsoft.Identity.Client/Http/DefaultRetryPolicy.cs Outdated Show resolved Hide resolved

Robbie-Microsoft marked this pull request as ready for review April 21, 2025 22:04

Robbie-Microsoft requested a review from a team as a code owner April 21, 2025 22:04

bgavrilMS reviewed Apr 23, 2025

View reviewed changes

src/client/Microsoft.Identity.Client/Http/DefaultRetryPolicy.cs Outdated Show resolved Hide resolved

Robbie-Microsoft added 5 commits April 23, 2025 17:17

Retry policies are now pre request instead of per HttpManager.

12e89cc

Merge branch 'main' into rginsburg_retry_policy_per_request

2d3b435

Improved unit test

132ec53

Addressed some GitHub feedback

fc7eafa

Implemented GitHub feedback

dc831fe

gladjohn reviewed Apr 30, 2025

View reviewed changes

src/client/Microsoft.Identity.Client/Http/HttpManager.cs Outdated Show resolved Hide resolved

src/client/Microsoft.Identity.Client/Http/HttpManager.cs Show resolved Hide resolved

src/client/Microsoft.Identity.Client/Http/ImdsRetryPolicy.cs Outdated Show resolved Hide resolved

Robbie-Microsoft added 17 commits April 30, 2025 14:02

Fixed broken unit tests, update public API

6576722

Undid public API changes

6d89f1c

Merge branch 'main' into rginsburg_retry_policy_per_request

a8cdac3

Fixed broken unit test and clarified public api

b68df2c

removed comment, adjusted unit test

aab8940

Merge branch 'main' into rginsburg_retry_policy_per_request

6e9cc07

Changed constants to PascalCase

4aedf33

Deleted file

4266a14

Undid file change from main

2153fc3

Reworked retry policy functionality. Created IMDS retry policy.

b82f872

Implemented GitHub Feedback

8b37d08

Created first retry unit test. The rest of the tests will be based of…

abe860f

…f of this one.

Added more ImdsRetryPolicy unit tests. Fixed bug discovered by unit t…

0eef7c6

…ests.

Finished all ImdsRetryPolicy unit tests

9faf287

Discovered bugs through unit tests, and fixed them. Improved ImdsRetr…

128f628

…yPolicy unit tests. Wrote UAMI unit tests for DefaultRetryPolicy.

Minor improvements to ImdsRetryPolicy tests

69a157a

Added option retryAfter header to mockHttpManager. Added more Defauly…

fe3ac7c

…RetryPolicy tests.

Robbie-Microsoft added 9 commits May 2, 2025 18:46

Added option retryAfter header to mockHttpManager. Added more Defauly…

c79f23d

…RetryPolicy tests.

Finished DefaultRetryPolicy unit tests. Edited some ImdsRetryPolicy u…

25ce41b

…nit tests. Fixed some bugs discovered by unit tests.

rebased branch from main to rginsburg_retry_policy_per_request

b33059c

Fixed some broken unit tests

2487799

Fixed all broken unit tests and made STS tests 100 times faster

eb785d6

whitespace

f5668c7

Merge branch 'rginsburg/imds_retry_policy' of https://github.com/Azur…

ec2090d

…eAD/microsoft-authentication-library-for-dotnet into rginsburg/imds_retry_policy

Final adjustment of unit tests

4cd60ed

Simplified params for DefaultRetryPolicy

1854cd3

Robbie-Microsoft marked this pull request as ready for review May 2, 2025 23:38

bgavrilMS reviewed May 3, 2025

View reviewed changes

src/client/Microsoft.Identity.Client/Http/ExponentialRetryStrategy.cs Outdated Show resolved Hide resolved

bgavrilMS reviewed May 3, 2025

View reviewed changes

src/client/Microsoft.Identity.Client/Http/LinearRetryStrategy.cs Outdated Show resolved Hide resolved

bgavrilMS reviewed May 3, 2025

View reviewed changes

src/client/Microsoft.Identity.Client/Http/DefaultRetryPolicy.cs Outdated Show resolved Hide resolved

bgavrilMS reviewed May 3, 2025

View reviewed changes

src/client/Microsoft.Identity.Client/Http/DefaultRetryPolicy.cs Outdated Show resolved Hide resolved

Robbie-Microsoft added 2 commits May 20, 2025 12:57

Implemented some GitHub feedback

001b32d

Merge branch 'main' into rginsburg/imds_retry_policy

a64391c

Robbie-Microsoft mentioned this pull request May 21, 2025

Created "retry" folder inside of "http" and updated all file paths #5300

Merged

Robbie-Microsoft and others added 8 commits May 21, 2025 12:14

Fixed build messages

bf41d92

adjusted unit test delay

d9a2dd3

Fixed build messages

f4433c7

removed unused import

fb9653a

added temporary logs for debugging CI issues

96a65cc

edited temporary logs

1be5bc1

Merge branch 'main' into rginsburg/imds_retry_policy

be8d712

Created "retry" folder inside of "http" and updated all file paths (#…

7c87c30

…5300)

Robbie-Microsoft mentioned this pull request May 29, 2025

Created Production and Test Retry Policy Factories, and adjusted unit tests #5308

Merged

Avery-Dunn mentioned this pull request May 30, 2025

Refactor retry logic and add special behavior for IMDS AzureAD/microsoft-authentication-library-for-java#960

Open

Robbie-Microsoft and others added 2 commits June 2, 2025 12:12

Merge branch 'main' into rginsburg/imds_retry_policy

735dc22

Robbie-Microsoft mentioned this pull request Jun 2, 2025

Moved RequestType enum from Constants to IRetryPolicyFactory #5316

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reworked retry policy functionality & Created IMDS retry policy #5231

Reworked retry policy functionality & Created IMDS retry policy #5231

Robbie-Microsoft commented Apr 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reworked retry policy functionality & Created IMDS retry policy #5231

Are you sure you want to change the base?

Reworked retry policy functionality & Created IMDS retry policy #5231

Conversation

Robbie-Microsoft commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Robbie-Microsoft commented Apr 11, 2025 •

edited

Loading