Skip to content

Implemented a Retry Policy for the IMDS Managed Identity Source #7614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Mar 27, 2025
Merged

Implemented a Retry Policy for the IMDS Managed Identity Source #7614

merged 20 commits into from
Mar 27, 2025

Conversation

Robbie-Microsoft
Copy link
Collaborator

@Robbie-Microsoft Robbie-Microsoft commented Mar 5, 2025 •
edited
Loading

The IMDS retry policy spec is located here.

The existing (linear) retry policy tests were moved out of Imds.spec.ts and into a new file, DefaultManagedIdentityRetryPolicy.spec.ts.

@github-actions github-actions bot added the msal-node Related to msal-node package label Mar 5, 2025
Robbie-Microsoft
Robbie-Microsoft commented Mar 5, 2025
View reviewed changes
@Robbie-Microsoft Robbie-Microsoft changed the title Added Exponential Retry Policy to Managed Identity Implemented a Retry Policy for the IMDS Managed Identity Source Mar 18, 2025
@github-actions github-actions bot added the msal-common Related to msal-common package label Mar 20, 2025
@Robbie-Microsoft Robbie-Microsoft marked this pull request as ready for review March 20, 2025 00:50
@github-actions github-actions bot added the documentation Related to documentation. label Mar 20, 2025
bgavrilMS
bgavrilMS reviewed Mar 20, 2025
View reviewed changes
Robbie-Microsoft
Robbie-Microsoft commented Mar 26, 2025
View reviewed changes
Copy link
Collaborator Author

@Robbie-Microsoft Robbie-Microsoft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: The tests are good, but I need to use mock values to reduce the times.

EDIT: Done

bgavrilMS
bgavrilMS reviewed Mar 26, 2025
View reviewed changes
bgavrilMS
bgavrilMS reviewed Mar 26, 2025
View reviewed changes
bgavrilMS
bgavrilMS reviewed Mar 26, 2025
View reviewed changes
@Robbie-Microsoft Robbie-Microsoft merged commit af94b11 into dev Mar 27, 2025
7 of 8 checks passed
@Robbie-Microsoft Robbie-Microsoft deleted the exponential_retry branch March 27, 2025 19:23
@Robbie-Microsoft Robbie-Microsoft mentioned this pull request Apr 21, 2025
Open
@Avery-Dunn Avery-Dunn mentioned this pull request May 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gladjohn gladjohn gladjohn left review comments

@bgavrilMS bgavrilMS bgavrilMS approved these changes

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@tnorling tnorling Awaiting requested review from tnorling tnorling is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz is a code owner

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@konstantin-msft konstantin-msft Awaiting requested review from konstantin-msft konstantin-msft is a code owner

@lalimasharda lalimasharda Awaiting requested review from lalimasharda lalimasharda is a code owner

@shylasummers shylasummers Awaiting requested review from shylasummers shylasummers is a code owner

Assignees
No one assigned
Labels
documentation Related to documentation. msal-common Related to msal-common package msal-node Related to msal-node package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Robbie-Microsoft @bgavrilMS @gladjohn