WEST MIDLANDS-JAN-ITP|SEGUN FOLAYAN|DATA GROUPS|SPRINT-1

[segunfolayan]

Learners, PR Template

Self checklist

• [x ] I have committed my files one by one, on purpose, and for a reason
• [ x] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• [ x] I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Questions

Ask any questions you have for your reviewer.

[day-lee]

Your logic is good, but the code looks a bit repetitive. The variable median is unnecessary. Could you refactor the code to return the result directly instead of assigning it to the variable median?

[segunfolayan]

function calculateMedian(list) {
const middleIndex = Math.floor(list.length / 2);

if (list.length % 2 === 1) {
return list[middleIndex];
}

return (list[middleIndex] + list[middleIndex - 1]) / 2; lists
}

module.exports = calculateMedian;

[segunfolayan]

Thank you

[day-lee]

Could you explain the characteristics of Set object and why we need to use the spread operator here?

[segunfolayan]

1. Uniqueness-It does not contain duplicates.
2. No index access- IT cannot be accessed using indices like arrays.
3. Insertion order-The values in the set are iterated in the order in which they are added.
4. Type flexibility- A Set can store values of any type (primitive or object), and even objects can be stored as unique values (by reference).
5. The spread operator is used to convert the Set back into an array.
6. Thank you

[day-lee]

JavaScript uses floating-point numbers, which are not always precise and lead to rounding issues.
If you test the following line expect(sum([1.6, 2.5, 3.1])).toBe(7.2) It will cause an error.
Can you refactor the sum() function so it passes this test case?

[segunfolayan]

function sum(elements) {
let total = 0;
for (let Index = 0; Index < elements.length; Index++) {
if (typeof elements[Index] === "number") {
total += elements[Index];
} else {
total = total + 0;
}
}
return parseFloat(total.toFixed(10));
}

.......................Thank you

[day-lee]

Can you add expect(sum([1.6, 2.5, 3.1])).toBe(7.2) and refactor the code to pass the test?

[segunfolayan]

function sum(elements) {
let total = 0;
for (let Index = 0; Index < elements.length; Index++) {
if (typeof elements[Index] === "number") {
total += elements[Index];
} else {
total = total + 0;
}
}
return parseFloat(total.toFixed(10));
}

module.exports = sum;

[segunfolayan]

Many Thanks

[day-lee]

Good job 👍 Let me know if you have any questions!