generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 94
WEST MIDLANDS-JAN-ITP|SEGUN FOLAYAN|DATA GROUPS|SPRINT-1 #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
segunfolayan
wants to merge
8
commits into
CodeYourFuture:main
Choose a base branch
from
segunfolayan:coursework/sprint1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
140d24b
120325sprint1
segunfolayan 94eb0a7
16032025Update
segunfolayan cc34f93
SumtestUpdate1803
segunfolayan cdd3a2a
finshforSprint1
segunfolayan bf06fce
alerted to commit
segunfolayan a48dcb1
test
segunfolayan deb0863
RemovingVaraiableMedianBasedOnFeedback
segunfolayan 23805bd
FixingSum.JSBasedOnFeedback
segunfolayan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,14 @@ | ||
// Fix this implementation | ||
// Start by running the tests for this function | ||
// If you're in the Sprint-1 directory, you can run `npm test -- fix` to run the tests in the fix directory | ||
|
||
module.exports = calculateMedian; | ||
|
||
function calculateMedian(list) { | ||
const middleIndex = Math.floor(list.length / 2); | ||
const median = list.splice(middleIndex, 1)[0]; | ||
return median; | ||
|
||
if (list.length % 2 === 1) { | ||
return list[middleIndex]; // Return the middle element for odd-length lists | ||
} | ||
|
||
return (list[middleIndex] + list[middleIndex - 1]) / 2; // Return the average of the two middle elements for even-length lists | ||
} | ||
|
||
module.exports = calculateMedian; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,3 +24,4 @@ describe("calculateMedian", () => { | |
expect(list).toEqual([1, 2, 3]); | ||
}); | ||
}); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,9 @@ | ||
function dedupe() {} | ||
|
||
|
||
|
||
function dedupe(arr) { | ||
return [...new Set(arr)]; | ||
} | ||
|
||
module.exports=dedupe; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,14 @@ | ||
function findMax(elements) { | ||
const newelement = elements.filter((x)=> typeof x=== "number"); | ||
if (newelement.length === 0){ | ||
return -Infinity; | ||
} | ||
else { | ||
return Math.max(...newelement) | ||
} | ||
|
||
; | ||
|
||
} | ||
|
||
module.exports = findMax; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain the characteristics of
Set object
and why we need to use the spread operator here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.