ITP_London | Maryna Romanova | Module_Data_Groups | Sprint-3 | AlarmClock #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarynaRomashca
changed the title
5 tasks
|
Shouldn't the alarm clock JS code be referred to your index html to run the functions - you only need one index html page |
fearcyf
reviewed
Apr 17, 2025
| function setAlarm() { | ||
| let firstReminder = +timeRemaining.innerHTML * 1000; | ||
|
|
||
| if (intervalId) { |
There was a problem hiding this comment.
This if statement does not seem complete
fearcyf
reviewed
Apr 17, 2025
| }, 100); | ||
| } | ||
|
|
||
| function pauseAlarm() { |
There was a problem hiding this comment.
Shouldn't the code refer to the button (listener) that makes pauseAlarm to happen?
fearcyf
reviewed
Apr 17, 2025
| } | ||
|
|
||
| intervalId = setInterval(() => { | ||
| firstReminder -= 100; |
|
I tried running your alarmclock.js file in my browser it's still not working. Made a few comments in your code. |
fearcyf
added
Review in progress
fearcyf
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.