Skip to content

Maryna Romanova - Sprint-3 #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Maryna Romanova - Sprint-3 #450

wants to merge 3 commits into from

Conversation

MarynaRomashca
Copy link

@MarynaRomashca MarynaRomashca commented Mar 29, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@MarynaRomashca MarynaRomashca added the Needs Review Participant to add when requesting review label Mar 29, 2025
fearcyf
fearcyf reviewed Apr 1, 2025
View reviewed changes
Sprint-3/alarmclock/alarmclock.js Outdated
const timeRemaining = document.querySelector("#timeValue");
const stepTime = 100
const startButton = document.querySelector("#set");
let isAudioPlaed = false;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a typo?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, english not my fist language, sorry for mistakes.

fearcyf
fearcyf reviewed Apr 1, 2025
View reviewed changes
Sprint-3/alarmclock/alarmclock.js

function setAlarm() {
let fistRemaider = +timeRemaining.innerHTML * 1000;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is fistRemaider a typo? if not just ignore

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixes my typo.

fearcyf
fearcyf reviewed Apr 1, 2025
View reviewed changes
Sprint-3/slideshow/style.css Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments in a different language - amend to English for submission purposes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments in other languages ​​have been removed.

@fearcyf
Copy link

fearcyf commented Apr 1, 2025

Add comments to submissions without them to show thought processes. Other points to be clarified have been noted.

@fearcyf fearcyf added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Apr 1, 2025
@fearcyf fearcyf self-assigned this Apr 1, 2025
@MarynaRomashca
Copy link
Author

Dear @fearcyf ,I have corrected everything you have indicated, please check. If everything is good, then approve my Sprint-3.

@MarynaRomashca MarynaRomashca added the Needs Review Participant to add when requesting review label Apr 6, 2025
@fearcyf fearcyf added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review Reviewed Volunteer to add when completing a review labels Apr 8, 2025
@fearcyf
Copy link

fearcyf commented Apr 8, 2025

In Step 3, you have to submit a PR for the Alarm Clock project and a PR for the Quote Generator project. Keep those two projects in separate PRs.

fearcyf
fearcyf reviewed Apr 8, 2025
View reviewed changes
Sprint-3/quote-generator/index.html Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random code is not displayed on page load - to be corrected

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's designed that way, you have to press the button first

fearcyf
fearcyf reviewed Apr 8, 2025
View reviewed changes
Sprint-3/alarmclock/alarmclock.js
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not working in my Browser. There areas to be reviewed specifically line 26. I advise breaking this down into multiple pull requests. Also look strengthening your process for handling inputs and checking out the clear interval function.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 26 of test.js to be precise

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is fixed

@fearcyf
Copy link

fearcyf commented Apr 8, 2025

Points to be addressed before pushing has been raised.

@fearcyf fearcyf added Reviewed Volunteer to add when completing a review Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Reviewed Volunteer to add when completing a review labels Apr 8, 2025
@fearcyf
Copy link

fearcyf commented Apr 15, 2025

Maryna, I thought you made changes to this Sprint's code - I'll change the label back to reviewed.

@fearcyf fearcyf added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 15, 2025
@MarynaRomashca
Copy link
Author

In Step 3, you have to submit a PR for the Alarm Clock project and a PR for the Quote Generator project. Keep those two projects in separate PRs.

@fearcyf As you requested, I have created two separate Pull Requests and submitted them for review:

#500

#501

Kindly asking you to review them. Thank you!

@MarynaRomashca MarynaRomashca added Complete Participant to add when work is complete and review comments have been addressed and removed Reviewed Volunteer to add when completing a review labels Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fearcyf fearcyf fearcyf left review comments

@halilibrahimcelik halilibrahimcelik Awaiting requested review from halilibrahimcelik

At least 1 approving review is required to merge this pull request.

Assignees

@cjyuan cjyuan

@fearcyf fearcyf

Labels
Complete Participant to add when work is complete and review comments have been addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarynaRomashca @fearcyf @cjyuan