Skip to content

ITP_London | Maryna Romanova | Module_Data_Groups | Sprint-3 | QuoteGenerator #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ITP_London | Maryna Romanova | Module_Data_Groups | Sprint-3 | QuoteGenerator #501

wants to merge 1 commit into from

Conversation

MarynaRomashca
Copy link

@MarynaRomashca MarynaRomashca commented Apr 17, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@MarynaRomashca MarynaRomashca changed the title QuoteGenerator | Maryna Romanova ITP_London | Maryna Romanova | Module_Data_Groups | Sprint-3 | QuoteGenerator Apr 17, 2025
@MarynaRomashca MarynaRomashca added the Needs Review Participant to add when requesting review label Apr 17, 2025
@MarynaRomashca MarynaRomashca mentioned this pull request Apr 17, 2025
Open
5 tasks
fearcyf
fearcyf reviewed Apr 17, 2025
View reviewed changes
Sprint-3/quote-generator/quotes.js
@@ -491,3 +501,10 @@ const quotes = [
];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be closing it off with this }

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last quote I mean

@fearcyf
Copy link

fearcyf commented Apr 17, 2025

This works in my browser, I made a syntax correction suggestion in your quotes.js file. It needed a } closing

@fearcyf fearcyf added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Apr 17, 2025
@fearcyf fearcyf added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fearcyf fearcyf fearcyf left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@cjyuan cjyuan

@fearcyf fearcyf

Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarynaRomashca @fearcyf @cjyuan