-
-
Notifications
You must be signed in to change notification settings - Fork 116
ITPJan | KATARZYNA KAZIMIERCZUK | STRUCTURING AND TESTING DATA | SPRINT1 #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -4,3 +4,5 @@ count = count + 1; | |||
|
|||
// Line 1 is a variable declaration, creating the count variable with an initial value of 0 | |||
// Describe what line 3 is doing, in particular focus on what = is doing | |||
|
|||
//in line 3 the count plus 1 is assigned to the previously declared and assigned variable count |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good explanation!
|
||
// dir: The part of the path before the last slash (/), which represents the directory. | ||
// base: The file name with the extension, which is everything after the last slash (/). | ||
// ext: The file extension, which is the part after the last period (.) in the base file name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good explanations
//gets a random number between 1 and 100 | ||
//math.floor random float between 0 and 1, < 1 | ||
//math.floor round down to int | ||
// + 1 to inlude max value so 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good step by step comments 👍
const 24hourClockTime = "08:53"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you noticed the errors here? Try running this file and see what happens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -12,11 +13,12 @@ console.log(`The percentage change is ${percentageChange}`); | |||
// Read the code and then answer the questions below | |||
|
|||
// a) How many function calls are there in this file? Write down all the lines where a function call is made | |||
|
|||
//3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What lines do you think are using a function call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What lines do you think are using a function call?
4 twice, 6 twice, 11
// b) How many function calls are there? | ||
|
||
// 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we count console.log()
as a function call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we do, my error
// Case 4: Identify Straight Angles: | ||
// When the angle is exactly 180 degrees, | ||
// Then the function should return "Straight angle" | ||
test("should identify straight angle (180°)", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good use of testing!
Good working on completing all the tasks 👍 |
thank you! |
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.