Improve error handling, fix base URL comparison bug #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… there's no matching recording in a cassette)
- Fix bug with comparing base URLs
nwithan8
changed the title
jchen293
previously approved these changes
Mar 23, 2023
Justintime50
previously approved these changes
Mar 23, 2023
src/main/java/com/easypost/easyvcr/clients/httpurlconnection/RecordableHttpURLConnection.java
Show resolved
Hide resolved
src/main/java/com/easypost/easyvcr/clients/httpurlconnection/RecordableHttpsURLConnection.java
Show resolved
Hide resolved
Justintime50
approved these changes
Mar 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more ambiguous NullPointerException when there's no matching recording in a cassette. Instead it's a RuntimeException (due to how the exceptions are coalesced internally) wrapping a VCRException, with a human-readable error message.
Before:
After:
Fixes a bug that was comparing the wrong data when matching by base URLs