Removed the eslint plugin from the dependencies. #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directly in the eslint config and should only be required when testing linting.
lukehb
approved these changes
Mar 27, 2025
mcottontensor
added a commit
to mcottontensor/PixelStreamingInfrastructure
that referenced
this pull request
Apr 3, 2025
Removed the eslint plugin from the dependencies. (cherry picked from commit da7ed8f) # Conflicts: # package-lock.json
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mcottontensor
added a commit
that referenced
this pull request
Apr 3, 2025
[UE5.5] Merge pull request #549 from mcottontensor/eslint-plugin-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement:
The lint plugin shouldn't be required for anything but linting. Having it in the dependencies shouldn't be needed.
Solution
The lint config now directly imports the plugin by path rather than package name.