Skip to content

Removed the eslint plugin from the dependencies. #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

Removed the eslint plugin from the dependencies. #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34a9255
Removed the eslint plugin from the dependencies. It's now referenced
mcottontensor Mar 27, 2025
22348fa
Merge branch 'EpicGamesExt:master' into eslint-plugin-fix
mcottontensor Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@
"typedoc": "^0.28.0",
"typedoc-plugin-markdown": "^4.4.2",
"typescript": "^5.7.3",
"typescript-eslint": "^8.24.0",
"@epicgames-ps/eslint-plugin-check-copyright": "*"
"typescript-eslint": "^8.24.0"
},
"dependencies": {
"@protobuf-ts/runtime": "^2.9.4",
Expand Down
1 change: 0 additions & 1 deletion Extras/JSStreamer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ FROM node:20-bookworm
## Maybe something like: docker build -t epicgames/jsstreamer:latest -f ./Extras/JSStreamer/Dockerfile .

WORKDIR /streamer
COPY /Extras/eslint/plugin-check-copyright ./Extras/eslint/plugin-check-copyright
COPY /Common ./Common
COPY /Extras/JSStreamer ./Extras/JSStreamer
COPY ./package.json ./package.json
Expand Down
3 changes: 1 addition & 2 deletions Extras/JSStreamer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@
"webpack": "^5.97.1",
"webpack-cli": "^6.0.1",
"webpack-dev-server": "^5.2.0",
"webpack-node-externals": "^3.0.0",
"@epicgames-ps/eslint-plugin-check-copyright": "*"
"webpack-node-externals": "^3.0.0"
},
"dependencies": {
"@epicgames-ps/lib-pixelstreamingcommon-ue5.5": "*"
Expand Down
1 change: 0 additions & 1 deletion Extras/SS_Test/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ COPY NODE_VERSION ./NODE_VERSION
COPY package.json ./package.json
COPY Common/ ./Common
COPY Extras/SS_Test/ ./Extras/SS_Test
COPY Extras/eslint/plugin-check-copyright ./Extras/eslint/plugin-check-copyright

RUN npm i
RUN cd Common && npm i && npm run build
Expand Down
3 changes: 1 addition & 2 deletions Extras/SS_Test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"@types/node": "^20.10.1",
"@types/ws": "^8.5.10",
"rimraf": "^5.0.5",
"typescript": "^5.3.2",
"@epicgames-ps/eslint-plugin-check-copyright": "*"
"typescript": "^5.3.2"
}
}
1 change: 0 additions & 1 deletion Frontend/implementations/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
},
"dependencies": {
"@epicgames-ps/lib-pixelstreamingfrontend-ue5.5": "*",
"@epicgames-ps/eslint-plugin-check-copyright": "*",
"react": "^19.0.0",
"react-dom": "^19.0.0"
}
Expand Down
3 changes: 1 addition & 2 deletions Frontend/implementations/typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
},
"dependencies": {
"@epicgames-ps/lib-pixelstreamingfrontend-ue5.5": "*",
"@epicgames-ps/lib-pixelstreamingfrontend-ui-ue5.5": "*",
"@epicgames-ps/eslint-plugin-check-copyright": "*"
"@epicgames-ps/lib-pixelstreamingfrontend-ui-ue5.5": "*"
}
}
3 changes: 1 addition & 2 deletions Frontend/library/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@
"rimraf": "^6.0.1",
"ts-jest": "^29.2.5",
"typescript": "^5.7.3",
"typescript-eslint": "^8.24.0",
"@epicgames-ps/eslint-plugin-check-copyright": "*"
"typescript-eslint": "^8.24.0"
},
"dependencies": {
"@epicgames-ps/lib-pixelstreamingcommon-ue5.5": "^0.2.9",
Expand Down
3 changes: 1 addition & 2 deletions Frontend/ui-library/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
"nodemon": "^3.1.9",
"rimraf": "^6.0.1",
"typescript": "^5.7.3",
"typescript-eslint": "^8.24.0",
"@epicgames-ps/eslint-plugin-check-copyright": "*"
"typescript-eslint": "^8.24.0"
},
"dependencies": {
"@babel/runtime": "^7.26.10",
Expand Down
3 changes: 1 addition & 2 deletions Signalling/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@
"typedoc": "^0.28.0",
"typedoc-plugin-markdown": "^4.4.2",
"typescript": "^5.7.3",
"typescript-eslint": "^8.24.0",
"@epicgames-ps/eslint-plugin-check-copyright": "*"
"typescript-eslint": "^8.24.0"
},
"dependencies": {
"express": "^4.21.2",
Expand Down
1 change: 0 additions & 1 deletion SignallingWebServer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ FROM node:lts
WORKDIR /SignallingWebServer
COPY NODE_VERSION ./NODE_VERSION
COPY package.json ./package.json
COPY /Extras/eslint/plugin-check-copyright ./Extras/eslint/plugin-check-copyright
COPY /Common ./Common
COPY /Signalling ./Signalling
COPY /SignallingWebServer ./SignallingWebServer
Expand Down
3 changes: 1 addition & 2 deletions SignallingWebServer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@
"eslint-plugin-tsdoc": "^0.4.0",
"rimraf": "^6.0.1",
"typescript": "^5.7.3",
"typescript-eslint": "^8.24.0",
"@epicgames-ps/eslint-plugin-check-copyright": "*"
"typescript-eslint": "^8.24.0"
},
"dependencies": {
"@epicgames-ps/lib-pixelstreamingsignalling-ue5.5": "*",
Expand Down
2 changes: 1 addition & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import eslint from '@eslint/js';
import prettierPluginRecommended from 'eslint-plugin-prettier/recommended';
import tseslint from 'typescript-eslint';
import checkCopyrightPlugin from '@epicgames-ps/eslint-plugin-check-copyright'
import checkCopyrightPlugin from './Extras/eslint/plugin-check-copyright/index.js'

export default tseslint.config(
eslint.configs.recommended,
Expand Down
18 changes: 2 additions & 16 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
"Extras/FrontendTests",
"Extras/MinimalStreamTester",
"Extras/SS_Test",
"Extras/mediasoup-sdp-bridge",
"Extras/eslint/plugin-check-copyright"
"Extras/mediasoup-sdp-bridge"
],
"private": true,
"scripts": {
Expand All @@ -28,7 +27,6 @@
"pre-commit-lint"
],
"devDependencies": {
"@epicgames-ps/eslint-plugin-check-copyright": "*",
"eslint": "^9.22.0",
"typescript-eslint": "^8.26.1",
"lint-staged": "^15.3.0",
Expand Down