update phpdoc for TagHandler::invalidateTags #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -106,6 +106,10 @@ public function addTags(array $tags) | |||
| * Invalidate cache entries that contain any of the specified tags in their | |||
| * tag header. | |||
| * | |||
| * The cache manager is told to invalidate all content with the specified tags | |||
| * and invalidation is dispatched on request termination. To immediately | |||
There was a problem hiding this comment.
Not just request termination, right? Also command termination, so more generally, kernel termination.
There was a problem hiding this comment.
true, kernel terminate would be the right thing to say here. maybe even be explicit that commands are covered as well.
dbu
force-pushed
the
improve-invalidate-doc
branch
from
7275edf to
66795df
Compare
|
improved the wording |
ddeboer
added a commit
that referenced
this pull request
Jun 25, 2015
update phpdoc for TagHandler::invalidateTags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix FriendsOfSymfony/FOSHttpCacheBundle#228