Extend styleci config to check more code style rules #666
Conversation
.styleci.yml
Outdated
| - return | ||
| disabled: | ||
| - align_double_arrow | ||
| - concat_without_spaces |
There was a problem hiding this comment.
Do you want to also turn on concat_with_spaces?
There was a problem hiding this comment.
yes let's do that!
.styleci.yml
Outdated
| disabled: | ||
| - align_double_arrow | ||
| - concat_without_spaces | ||
| - no_multiline_whitespace_before_semicolons |
There was a problem hiding this comment.
There is a less aggressive version of this fixer you might want to replace it with. I can't remember it's name, but I think it does something along the lines of removing the whitespace, but not in multiline contexts.
There was a problem hiding this comment.
Do you mean this one "no_singleline_whitespace_before_semicolons" ?
There was a problem hiding this comment.
Yeh, that sounds right. :)
There was a problem hiding this comment.
So I keep this one disabled and enable the singleline one, right?
|
Also, might be an idea to hold off on these changes, until the PHP 7 PR has gone through, or not to commit the CS changes in this PR? |
|
I thought it would be good to do these CS changes here and let the php7 pr rebase when this is merged. This way that pr has less changes, more relevant changes and makes it easier to review imo. |
|
Since the changes in this PR are autogenerated, I think this one should wait tbh. |
acrobat
force-pushed
the
styleci-tweaks
branch
2 times, most recently
from
72a004d to
66b9fe4
Compare
acrobat
force-pushed
the
styleci-tweaks
branch
from
66b9fe4 to
7970165
Compare
acrobat
force-pushed
the
styleci-tweaks
branch
from
7970165 to
ead9bfd
Compare
|
@Nyholm any remarks/objections before merging this? I thinks we agreed on splitting the php 7 pr, so this one can be merged before. |
Use the recommended preset to add some more code style checks.
Btw pr/issue 666 😱