Extend styleci config to check more code style rules

.styleci.yml

@@ -1,4 +1,5 @@
-preset: psr2
+preset: recommended
 
-enabled:
-  - return
+disabled:
+  - align_double_arrow
+  - no_multiline_whitespace_before_semicolons

lib/Github/Api/AbstractApi.php

@@ -90,7 +90,7 @@ public function setPerPage($perPage)
      *
      * @return array|string
      */
-    protected function get($path, array $parameters = array(), array $requestHeaders = array())
+    protected function get($path, array $parameters = [], array $requestHeaders = [])
     {
         if (null !== $this->page && !isset($parameters['page'])) {
             $parameters['page'] = $this->page;
@@ -120,7 +120,7 @@ protected function get($path, array $parameters = array(), array $requestHeaders
      *
      * @return \Psr\Http\Message\ResponseInterface
      */
-    protected function head($path, array $parameters = array(), array $requestHeaders = array())
+    protected function head($path, array $parameters = [], array $requestHeaders = [])
     {
         if (array_key_exists('ref', $parameters) && is_null($parameters['ref'])) {
             unset($parameters['ref']);
@@ -140,7 +140,7 @@ protected function head($path, array $parameters = array(), array $requestHeader
      *
      * @return array|string
      */
-    protected function post($path, array $parameters = array(), array $requestHeaders = array())
+    protected function post($path, array $parameters = [], array $requestHeaders = [])
     {
         return $this->postRaw(
             $path,
@@ -158,7 +158,7 @@ protected function post($path, array $parameters = array(), array $requestHeader
      *
      * @return array|string
      */
-    protected function postRaw($path, $body, array $requestHeaders = array())
+    protected function postRaw($path, $body, array $requestHeaders = [])
     {
         $response = $this->client->getHttpClient()->post(
             $path,
@@ -178,7 +178,7 @@ protected function postRaw($path, $body, array $requestHeaders = array())
      *
      * @return array|string
      */
-    protected function patch($path, array $parameters = array(), array $requestHeaders = array())
+    protected function patch($path, array $parameters = [], array $requestHeaders = [])
     {
         $response = $this->client->getHttpClient()->patch(
             $path,
@@ -198,7 +198,7 @@ protected function patch($path, array $parameters = array(), array $requestHeade
      *
      * @return array|string
      */
-    protected function put($path, array $parameters = array(), array $requestHeaders = array())
+    protected function put($path, array $parameters = [], array $requestHeaders = [])
     {
         $response = $this->client->getHttpClient()->put(
             $path,
@@ -218,7 +218,7 @@ protected function put($path, array $parameters = array(), array $requestHeaders
      *
      * @return array|string
      */
-    protected function delete($path, array $parameters = array(), array $requestHeaders = array())
+    protected function delete($path, array $parameters = [], array $requestHeaders = [])
     {
         $response = $this->client->getHttpClient()->delete(
             $path,

lib/Github/Api/AcceptHeaderTrait.php

@@ -11,50 +11,51 @@ trait AcceptHeaderTrait
 {
     protected $acceptHeaderValue = null;
 
-    protected function get($path, array $parameters = array(), array $requestHeaders = array())
+    protected function get($path, array $parameters = [], array $requestHeaders = [])
     {
         return parent::get($path, $parameters, $this->mergeHeaders($requestHeaders));
     }
 
-    protected function head($path, array $parameters = array(), array $requestHeaders = array())
+    protected function head($path, array $parameters = [], array $requestHeaders = [])
     {
         return parent::head($path, $parameters, $this->mergeHeaders($requestHeaders));
     }
 
-    protected function post($path, array $parameters = array(), array $requestHeaders = array())
+    protected function post($path, array $parameters = [], array $requestHeaders = [])
     {
         return parent::post($path, $parameters, $this->mergeHeaders($requestHeaders));
     }
 
-    protected function postRaw($path, $body, array $requestHeaders = array())
+    protected function postRaw($path, $body, array $requestHeaders = [])
     {
         return parent::postRaw($path, $body, $this->mergeHeaders($requestHeaders));
     }
 
-    protected function patch($path, array $parameters = array(), array $requestHeaders = array())
+    protected function patch($path, array $parameters = [], array $requestHeaders = [])
     {
         return parent::patch($path, $parameters, $this->mergeHeaders($requestHeaders));
     }
 
-    protected function put($path, array $parameters = array(), array $requestHeaders = array())
+    protected function put($path, array $parameters = [], array $requestHeaders = [])
     {
         return parent::put($path, $parameters, $this->mergeHeaders($requestHeaders));
     }
 
-    protected function delete($path, array $parameters = array(), array $requestHeaders = array())
+    protected function delete($path, array $parameters = [], array $requestHeaders = [])
     {
         return parent::delete($path, $parameters, $this->mergeHeaders($requestHeaders));
     }
 
     /**
-     * Append a new accept header on all requests
+     * Append a new accept header on all requests.
+     *
      * @return array
      */
-    private function mergeHeaders(array $headers = array())
+    private function mergeHeaders(array $headers = [])
     {
-        $default = array();
+        $default = [];
         if ($this->acceptHeaderValue) {
-            $default = array('Accept' => $this->acceptHeaderValue);
+            $default = ['Accept' => $this->acceptHeaderValue];
         }
 
         return array_merge($default, $headers);

lib/Github/Api/Apps.php

@@ -4,12 +4,13 @@
 
 /**
  * @link   https://developer.github.com/v3/apps/
+ *
  * @author Nils Adermann <[email protected]>
  */
 class Apps extends AbstractApi
 {
     /**
-     * Create an access token for an installation
+     * Create an access token for an installation.
      *
      * @param int $installationId An integration installation id
      * @param int $userId         An optional user id on behalf of whom the
@@ -19,7 +20,7 @@ class Apps extends AbstractApi
      */
     public function createInstallationToken($installationId, $userId = null)
     {
-        $parameters = array();
+        $parameters = [];
         if ($userId) {
             $parameters['user_id'] = $userId;
         }
@@ -50,7 +51,7 @@ public function findInstallations()
      */
     public function listRepositories($userId = null)
     {
-        $parameters = array();
+        $parameters = [];
         if ($userId) {
             $parameters['user_id'] = $userId;
         }

lib/Github/Api/Authorizations.php

@@ -6,6 +6,7 @@
  * Creating, deleting and listing authorizations.
  *
  * @link   http://developer.github.com/v3/oauth_authorizations/
+ *
  * @author Evgeniy Guseletov <[email protected]>
  */
 class Authorizations extends AbstractApi
@@ -36,13 +37,13 @@ public function show($clientId)
      * Create an authorization.
      *
      * @param array $params
-     * @param null $OTPCode
+     * @param null  $OTPCode
      *
      * @return array
      */
     public function create(array $params, $OTPCode = null)
     {
-        $headers = null === $OTPCode ? array() : array('X-GitHub-OTP' => $OTPCode);
+        $headers = null === $OTPCode ? [] : ['X-GitHub-OTP' => $OTPCode];
 
         return $this->post('/authorizations', $params, $headers);
     }

lib/Github/Api/CurrentUser.php

@@ -2,16 +2,17 @@
 
 namespace Github\Api;
 
-use Github\Api\CurrentUser\PublicKeys;
 use Github\Api\CurrentUser\Emails;
 use Github\Api\CurrentUser\Followers;
 use Github\Api\CurrentUser\Memberships;
 use Github\Api\CurrentUser\Notifications;
-use Github\Api\CurrentUser\Watchers;
+use Github\Api\CurrentUser\PublicKeys;
 use Github\Api\CurrentUser\Starring;
+use Github\Api\CurrentUser\Watchers;
 
 /**
  * @link   http://developer.github.com/v3/users/
+ *
  * @author Joseph Bielawski <[email protected]>
  * @author Felipe Valtl de Mello <[email protected]>
  */
@@ -45,9 +46,9 @@ public function follow()
 
     public function followers($page = 1)
     {
-        return $this->get('/user/followers', array(
-            'page' => $page
-        ));
+        return $this->get('/user/followers', [
+            'page' => $page,
+        ]);
     }
 
     /**
@@ -58,9 +59,9 @@ public function followers($page = 1)
      *
      * @return array
      */
-    public function issues(array $params = array(), $includeOrgIssues = true)
+    public function issues(array $params = [], $includeOrgIssues = true)
     {
-        return $this->get($includeOrgIssues ? '/issues' : '/user/issues', array_merge(array('page' => 1), $params));
+        return $this->get($includeOrgIssues ? '/issues' : '/user/issues', array_merge(['page' => 1], $params));
     }
 
     /**
@@ -118,11 +119,11 @@ public function teams()
      */
     public function repositories($type = 'owner', $sort = 'full_name', $direction = 'asc')
     {
-        return $this->get('/user/repos', array(
+        return $this->get('/user/repos', [
             'type' => $type,
             'sort' => $sort,
-            'direction' => $direction
-        ));
+            'direction' => $direction,
+        ]);
     }
 
     /**
@@ -138,9 +139,9 @@ public function watchers()
      */
     public function watched($page = 1)
     {
-        return $this->get('/user/watched', array(
-            'page' => $page
-        ));
+        return $this->get('/user/watched', [
+            'page' => $page,
+        ]);
     }
 
     /**
@@ -156,9 +157,9 @@ public function starring()
      */
     public function starred($page = 1)
     {
-        return $this->get('/user/starred', array(
-            'page' => $page
-        ));
+        return $this->get('/user/starred', [
+            'page' => $page,
+        ]);
     }
 
     /**
@@ -174,19 +175,19 @@ public function subscriptions()
      *
      * @param array $params
      */
-    public function installations(array $params = array())
+    public function installations(array $params = [])
     {
-        return $this->get('/user/installations', array_merge(array('page' => 1), $params));
+        return $this->get('/user/installations', array_merge(['page' => 1], $params));
     }
 
     /**
      * @link https://developer.github.com/v3/integrations/installations/#list-repositories-accessible-to-the-user-for-an-installation
      *
-     * @param string $installationId  the ID of the Installation
-     * @param array $params
+     * @param string $installationId the ID of the Installation
+     * @param array  $params
      */
-    public function repositoriesByInstallation($installationId, array $params = array())
+    public function repositoriesByInstallation($installationId, array $params = [])
     {
-        return $this->get(sprintf('/user/installations/%s/repositories', $installationId), array_merge(array('page' => 1), $params));
+        return $this->get(sprintf('/user/installations/%s/repositories', $installationId), array_merge(['page' => 1], $params));
     }
 }

lib/Github/Api/CurrentUser/Emails.php

@@ -7,6 +7,7 @@
 
 /**
  * @link   http://developer.github.com/v3/users/emails/
+ *
  * @author Joseph Bielawski <[email protected]>
  */
 class Emails extends AbstractApi
@@ -49,7 +50,7 @@ public function allPublic()
     public function add($emails)
     {
         if (is_string($emails)) {
-            $emails = array($emails);
+            $emails = [$emails];
         } elseif (0 === count($emails)) {
             throw new InvalidArgumentException();
         }
@@ -71,7 +72,7 @@ public function add($emails)
     public function remove($emails)
     {
         if (is_string($emails)) {
-            $emails = array($emails);
+            $emails = [$emails];
         } elseif (0 === count($emails)) {
             throw new InvalidArgumentException();
         }
@@ -80,7 +81,7 @@ public function remove($emails)
     }
 
     /**
-     * Toggle primary email visibility
+     * Toggle primary email visibility.
      *
      * @link https://developer.github.com/v3/users/emails/#toggle-primary-email-visibility
      *

lib/Github/Api/CurrentUser/Followers.php

@@ -6,6 +6,7 @@
 
 /**
  * @link   http://developer.github.com/v3/users/followers/
+ *
  * @author Joseph Bielawski <[email protected]>
  */
 class Followers extends AbstractApi
@@ -21,9 +22,9 @@ class Followers extends AbstractApi
      */
     public function all($page = 1)
     {
-        return $this->get('/user/following', array(
-            'page' => $page
-        ));
+        return $this->get('/user/following', [
+            'page' => $page,
+        ]);
     }
 
     /**

lib/Github/Api/CurrentUser/Memberships.php

@@ -33,7 +33,7 @@ public function organization($organization)
     }
 
     /**
-     * Edit your organization membership
+     * Edit your organization membership.
      *
      * @link https://developer.github.com/v3/orgs/members/#edit-your-organization-membership
      *
@@ -43,6 +43,6 @@ public function organization($organization)
      */
     public function edit($organization)
     {
-        return $this->patch('/user/memberships/orgs/'.rawurlencode($organization), array('state' => 'active'));
+        return $this->patch('/user/memberships/orgs/'.rawurlencode($organization), ['state' => 'active']);
     }
 }