Skip to content

Tests/Tokenizer: make it easier to debug recurseScopeMap() default keyword tests #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

Tests/Tokenizer: make it easier to debug recurseScopeMap() default keyword tests #902

merged 1 commit into from
Mar 25, 2025

Conversation

rodrigoprimo
Copy link
Contributor

Description

As discussed in #813 (review), this PR appends the test marker's name to the end of each assertion's $message. This should make it easier to identify which test case caused a given test to fail.

Suggested changelog entry

N/A

Related issues/external references

Follow up to #813

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

@rodrigoprimo
Tests/Tokenizer: make it easier to debug recurseScopeMap() default …
43a003e 
…keyword tests

This commit appends the test marker's name to the end of each
assertion's `$message`. This should make it easier to identify which
test case caused a given test to fail.
jrfnl
jrfnl approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rodrigoprimo LGTM.

@jrfnl jrfnl added this to the 3.12.1 milestone Mar 25, 2025
@jrfnl jrfnl merged commit 615e25a into PHPCSStandards:master Mar 25, 2025
48 checks passed
@jrfnl jrfnl deleted the display-test-markers-in-error-messages branch March 25, 2025 12:49
@rodrigoprimo rodrigoprimo mentioned this pull request Mar 25, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfnl jrfnl jrfnl approved these changes

Assignees
No one assigned
Labels
Core Component: Tokenizer Type: chores/QA
Projects
None yet
Milestone
3.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@rodrigoprimo @jrfnl