Tests/Tokenizer: use markers for the testSwitchDefault() test
#904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using markers instead of offsets help stabilize the tests.
rodrigoprimo
added
Type: chores/QA
Core Component: Tokenizer
and removed
Status: triage
labels
jrfnl
reviewed
Mar 30, 2025
tests/Core/Tokenizers/Tokenizer/RecurseScopeMapDefaultKeywordConditionsTest.php
Outdated
Show resolved
Hide resolved
parameter names of the test method
jrfnl
reviewed
Apr 1, 2025
tests/Core/Tokenizers/Tokenizer/RecurseScopeMapDefaultKeywordConditionsTest.php
Outdated
Show resolved
Hide resolved
tests/Core/Tokenizers/Tokenizer/RecurseScopeMapDefaultKeywordConditionsTest.php
Outdated
Show resolved
Hide resolved
jrfnl
reviewed
Apr 7, 2025
tests/Core/Tokenizers/Tokenizer/RecurseScopeMapDefaultKeywordConditionsTest.php
Outdated
Show resolved
Hide resolved
jrfnl
pushed a commit
that referenced
this pull request
Apr 8, 2025
* Tests/Tokenizer: use markers for the `testSwitchDefault()` test Using markers instead of offsets help stabilize the tests. * Fix: keys in sub-arrays in data provider methods should match the parameter names of the test method * Fix: marker passed to the error message of two assertions * Include all possible token types when looking for the condition stop token * Move list of condition stop tokens to a class property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the
RecurseScopeMapDefaultKeywordConditionsTest::testSwitchDefault()test method by replacing offsets with markers. This helps stabilize the tests.This PR is the last one in a series of PRs to improve the
RecurseScopeMapDefaultKeywordConditionsTesttests. The other PRs in this series are #813, #850, #870, and #902.Types of changes
PR checklist