Skip to content

Added strand sort #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 23 commits into from
Closed

Added strand sort #1981

wants to merge 23 commits into from

Conversation

l3str4nge
Copy link
Member

Describe your change:

I didn't find strand sort (https://en.wikipedia.org/wiki/Strand_sort) implemenation so here it is.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

l3str4nge and others added 23 commits April 29, 2020 11:25
@l3str4nge
Added Burkes dithering algorithm
201ca25
@l3str4nge
Added unit tests for burkes algorithm
fa79687
@l3str4nge
Fix burkes algorithm
a157b47
@l3str4nge
Added some additional information
b92ccd3
@l3str4nge
Fixed CI tests
0f2bbde
@l3str4nge @cclauss
Update digital_image_processing/dithering/burkes.py
611e113 
Co-Authored-By: Christian Clauss <[email protected]>
@l3str4nge @cclauss
Update digital_image_processing/dithering/burkes.py
c872fc6 
Co-Authored-By: Christian Clauss <[email protected]>
@l3str4nge @cclauss
Update digital_image_processing/dithering/burkes.py
8757600 
Co-Authored-By: Christian Clauss <[email protected]>
@cclauss
Propogate the += and add a doctest
6b8e069
@l3str4nge
Fix doctest
f33f4ca
@cclauss
@staticmethod --> @ classmethod to ease testing
4cd6aa7
@cclauss
def test_burkes(file_path):
bea2a4d
@l3str4nge
Fix for mypy checks
114ee8d
@l3str4nge
Fix variable order in get_greyscale
66190e4
@l3str4nge
Fix get_greyscale method
823a98f
@l3str4nge
Fix get_greyscale method
b827c55
@cclauss
3.753
6ce1e16
@l3str4nge
Added Nearest Neighbour algorithm
9ac0666
@l3str4nge
technique -> techniques
5e10f48
@l3str4nge
Added Nearest neighbour algorithm
5bb46d3
@l3str4nge
Fix conflicts
dc2e794
@l3str4nge
Added strand sort
940548a
@l3str4nge
Fix conflicts after merge with upstream
c0421c3
@l3str4nge
Copy link
Member Author

23 commits o.O I will reopen this PR.

@l3str4nge l3str4nge closed this May 14, 2020
cclauss
cclauss reviewed May 14, 2020
View reviewed changes
sorts/strand_sort.py
import operator


def strand_sort(arr: list, solution: list, _operator: callable):
Copy link
Member

@cclauss cclauss May 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sort would be easier to use (and test) if it returned a list instead of requiring the caller to allocate and pass in a solution list.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be cool if _operator was an optional parameter with the default set to operator.gt.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss Could we move review to reopened PR: #1982? This PR was made by mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l3str4nge @cclauss