Skip to content

Added strand sort #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 17, 2020
Merged

Added strand sort #1982

merged 5 commits into from
May 17, 2020

Conversation

l3str4nge
Copy link
Member

Describe your change:

I didn't find strand sort (https://en.wikipedia.org/wiki/Strand_sort) implemenation so here it is.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@l3str4nge l3str4nge mentioned this pull request May 14, 2020
Closed
14 tasks
cclauss
cclauss requested changes May 14, 2020
View reviewed changes
@l3str4nge
Copy link
Member Author

@cclauss should I refactor something more?

@cclauss cclauss merged commit bc8e8f0 into TheAlgorithms:master May 17, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@l3str4nge @stokhos
Added strand sort (TheAlgorithms#1982)
36ca945 
* Added strand sort

* Review changes

* Remove boilerplate code

* Fixed flake error: E252

* Added missing return type hint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l3str4nge @cclauss