This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(ng-closure-runner): upgrade to version 0.2.4 #15307
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 0.2.4's `minErr` implementation is up to date with the one in core. Fixes angular#14971
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
Version 0.2.4's `minErr` implementation is up to date with the one in core. Fixes angular#14971 Closes angular#15307
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
Version 0.2.4's `minErr` implementation is up to date with the one in core. Fixes angular#14971 Closes angular#15307
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
Version 0.2.4's `minErr` implementation is up to date with the one in core. Fixes angular#14971 Closes angular#15307
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
Version 0.2.4's `minErr` implementation is up to date with the one in core. Fixes angular#14971 Closes angular#15307
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
Version 0.2.4's `minErr` implementation is up to date with the one in core. Fixes angular#14971 Closes angular#15307
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
Version 0.2.4's `minErr` implementation is up to date with the one in core. Fixes angular#14971 Closes angular#15307
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Chore.
What is the current behavior? (You can also link to an open issue here)
We are using
ngClosureRunnerversion 0.2.3, which has an outdated implementation ofminErr. Thus the minified versions have a slightly different imlementation ofminErr.See also #14971.
What is the new behavior (if this is a feature change)?
We will be using
ngClosureRunnerversion 0.2.4, which has the updated implementation ofminErr.Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Docs have been added / updated (for bug fixes / features)Other information:
Fixes #14971
Depends on angular/ng-closure-runner#11.
Do not merge before v0.2.4 has been actually released 😃