This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(browserstack): Update browserstacktunnel-wrapper, fix options #15892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the latest version of the package works correctly (the backend for it at BrowserStack is not versioned) and the options have changed in the new version of the package. Also, iOS 8.0 is no longer available on BrowserStack, only 8.3 is. Instead, this commit changes it to 9.3 as we shouldn't be testing on 8 anymore anyway.
|
We don't actually test on Browserstack via Travis, does this really fix something? |
|
You can run it manually: The BrowserStack launchers are defined in I have a BrowserStack account so I use it sometimes to run tests without submitting a PR. |
|
Oh cool, I didn't know. That's pretty neat |
|
LGTM |
1 task
mgol
added a commit
that referenced
this pull request
Apr 25, 2017
Only the latest version of the package works correctly (the backend for it at BrowserStack is not versioned) and the options have changed in the new version of the package. Also, iOS 8.0 is no longer available on BrowserStack, only 8.3 is. Instead, this commit changes it to 9.3 as we shouldn't be testing on 8 anymore anyway. (a late cherry-pick of ad0bb83) Closes #15892
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the latest version of the package works correctly (the backend for it at
BrowserStack is not versioned) and the options have changed in the new version
of the package.
Also, iOS 8.0 is no longer available on BrowserStack, only 8.3 is. Instead,
this commit changes it to 9.3 as we shouldn't be testing on 8 anymore anyway.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix in the testing infrastructure.
What is the current behavior? (You can also link to an open issue here)
The Browserstack wrapper doesn't set the local identified correctly, old wrapper is used that uses incorrect parameter names.
What is the new behavior (if this is a feature change)?
Package got updated, params are fine again.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Tests for the changes have been added (for bug fixes / features)Docs have been added / updated (for bug fixes / features)Other information: