This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(browserstack): Update OS X, make iOS 8-10 available to test #15910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
approved these changes
Apr 12, 2017
| @@ -9,7 +9,7 @@ if [ "$JOB" == "ci-checks" ]; then | |||
| grunt ci-checks | |||
| elif [ "$JOB" == "unit" ]; then | |||
| if [ "$BROWSER_PROVIDER" == "browserstack" ]; then | |||
| BROWSERS="BS_Chrome,BS_Safari,BS_Firefox,BS_IE_9,BS_IE_10,BS_IE_11,BS_iOS" | |||
| BROWSERS="BS_Chrome,BS_Safari,BS_Firefox,BS_IE_9,BS_IE_10,BS_IE_11,BS_iOS_8,BS_iOS_9" | |||
|
@mgol - these changes are all for BrowserStack, right? |
|
OK |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Test config update.
What is the current behavior? (You can also link to an open issue here)
Only one iOS version can be tested via BrowserStack.
What is the new behavior (if this is a feature change)?
iOS 8.3, 9.3 & 10.0 can be tested.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Tests for the changes have been added (for bug fixes / features)Docs have been added / updated (for bug fixes / features)Other information:
Angular (2+) supports iOS 7+ but iOS 7 is very flakey on BrowserStack (see angular/angular#15916). It'd be good to at least try to support the same versions; making it possible to test via BrowserStack is the first step.