Skip to content

Remove module.id references #13883

Closed
@gregmagolan

Description

@gregmagolan

Bug, feature request, or proposal:

The module.id references should be removed from Angular Material once they are no longer needed in Google3. This will likely have to wait until Ivy is released.

What is the current behavior?

A work-around for the module.id references is needed when building Angular & Material from source downstream when using ts_devserver and ts_web_test_suite. See /src/module-id.js in angular/angular-bazel-example#228.

Without the work-around, you'll see a module is not defined error in the browser when running ts_dev_server and ts_web_test_suite will fail due to the same error.

Uncaught ReferenceError: module is not defined
    at eval (tree.ts:48)
    at Object.eval (tree.ts:59)
    at Object.execCb (bundle.min.js:1696)
    at Module.check (bundle.min.js:883)
    at Module.<anonymous> (bundle.min.js:1139)
    at bundle.min.js:134
    at bundle.min.js:1189
    at each (bundle.min.js:59)
    at Module.emit (bundle.min.js:1188)
    at Module.check (bundle.min.js:938)

What is the expected behavior?

This work-around can be removed once the references are no longer needed and removed.

What is the use-case or motivation for changing an existing behavior?

Simplify Angular + Material + Bazel adoption.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions