Skip to content

refactor: remove moduleId from all components #17626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2019
Merged

refactor: remove moduleId from all components #17626

merged 1 commit into from
Nov 6, 2019

Conversation

devversion
Copy link
Member

@devversion devversion commented Nov 6, 2019 •
edited
Loading

Removes all moduleId properties from components. We no longer
need them since we inline resources when building the library.

Closes #13883

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 6, 2019
@devversion
refactor: remove moduleId from all components
d9ab448 
Removes all `moduleId` properties from components. We no longer
need them since we inline resources when building the library.
@devversion devversion force-pushed the refactor/remove-module-id-properties branch from 776c654 to d9ab448 Compare November 6, 2019 10:55
@devversion devversion changed the title refactor: remove moduleId properties of components refactor: remove moduleId from all components Nov 6, 2019
@devversion devversion mentioned this pull request Nov 6, 2019
Closed
@devversion devversion added target: patch This PR is targeted for the next patch release P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful labels Nov 6, 2019
@devversion devversion added this to the 9.0.0 milestone Nov 6, 2019
@devversion devversion marked this pull request as ready for review November 6, 2019 11:16
@devversion
Copy link
Member Author

devversion commented Nov 6, 2019 •
edited
Loading

Caretaker: This needs a copybara transform to re-add moduleId back for components in google.

@devversion devversion added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Nov 6, 2019
crisbeto
crisbeto approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jelbourn
jelbourn approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

josephperrott
josephperrott approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Nov 6, 2019
@mmalerba mmalerba merged commit 049da95 into angular:master Nov 6, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@josephperrott josephperrott josephperrott approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

Remove module.id references
6 participants
@devversion @jelbourn @crisbeto @josephperrott @googlebot @mmalerba