Skip to content

bug(table): divider should sit within the baseline #8299

Closed
@ghost

Description

In the cource of reviewing #5862, I had a look at the specs of the divider and noticed that according to MD guidelines a divider should sit within the baseline of an element:

So, refered to the data table component, the height of a row + divider should be still 48px, but currently it's 49px:

This would match with the image in the specs, as the size marker, which is specified with the mentioned 48px, starts at the first pixel of the row but ends at the position of the divider:

What is the use-case or motivation for changing an existing behavior?

I know this is a very minor issue, I mean, it's about 1px (...although it gets more with each row...), but I thought since we want to follow the MD Guide, it's worth mentioning it.

Is there anything else we should know?

So, there are two solutions at the moment, setting box-sizing to border-box or giving the row a min-height of 47px. The latter would affect my open pull request(#8215).

Metadata

Metadata

Assignees

Labels

P4A relatively minor issue that is not relevant to core functions

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions