Skip to content

fix(table): set height of mat-header-row to 56px #8215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from Jan 12, 2018
Merged

fix(table): set height of mat-header-row to 56px #8215

merged 2 commits into from Jan 12, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 3, 2017

Fixes #8206

@ghost ghost requested a review from andrewseguin as a code owner November 3, 2017 15:07
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 3, 2017
josephperrott
josephperrott approved these changes Nov 6, 2017
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 6, 2017
@josephperrott
Copy link
Member

Note for caretaker: This will likely cause screendif failures.

@ghost
Copy link
Author

ghost commented Nov 7, 2017

Accidently merged master into. becce84 is the core commit of this PR.

@ghost ghost mentioned this pull request Nov 8, 2017
Closed
@jelbourn
Copy link
Member

Caretaker note: this does indeed cause a fair number of screenshot diff failures

@willshowell willshowell mentioned this pull request Dec 12, 2017
Closed
@jasiekmiko jasiekmiko mentioned this pull request Dec 13, 2017
Closed
@andrewseguin andrewseguin added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Dec 13, 2017
@andrewseguin andrewseguin merged commit 0c4ee2e into angular:master Jan 12, 2018
@andrewseguin andrewseguin added the target: patch This PR is targeted for the next patch release label Jan 12, 2018
andrewseguin pushed a commit to andrewseguin/components that referenced this pull request Jan 12, 2018
@andrewseguin
fix(table): set height of mat-header-row to 56px (angular#8215)
9777cab
@ghost ghost deleted the fix-height-header-row branch January 13, 2018 09:17
andrewseguin pushed a commit that referenced this pull request Jan 17, 2018
@andrewseguin
fix(table): set height of mat-header-row to 56px (#8215)
db0eb31
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephperrott @jelbourn @googlebot @andrewseguin